Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2874043002: Add --fatal-infos; hide --fatal-hints. (Closed)

Created:
3 years, 7 months ago by devoncarew
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 7 chunks +23 lines, -15 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/test/reporter_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
Make it clearer that our exit code is based on the severity of issues, and ...
3 years, 7 months ago (2017-05-10 17:47:38 UTC) #2
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-10 17:55:34 UTC) #3
danrubel
LGTM
3 years, 7 months ago (2017-05-10 18:11:45 UTC) #4
devoncarew
3 years, 7 months ago (2017-05-10 18:45:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1a5503fccaab258ec26961630b04d0f713b3acf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698