chrome/android/java/res/menu/photo_picker_menu.xml - Issue 2874033004: Photo Picker dialog: Make toolbar behave more like mocks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/menu/photo_picker_menu.xml

Issue 2874033004: Photo Picker dialog: Make toolbar behave more like mocks. (Closed)

Patch Set: Address feedback from Theresa Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 <?xml version="1.0" encoding="utf-8"?>
Theresa 2017/05/16 15:01:22 This is fully deleted right? Just checking, since This is fully deleted right? Just checking, since the codereview tool is marking it as "M" rather than "D". Finnur 2017/05/16 16:08:02 Yeah, it looks that way on my machine (the file is Yeah, it looks that way on my machine (the file is gone). Weird.
2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->

5

6 <menu xmlns:android="http://schemas.android.com/apk/res/android"

7 xmlns:chrome="http://schemas.android.com/apk/res-auto" >

8

9 <group android:id="@+id/photo_picker_normal_menu_group" >

10 <item

11 android:id="@+id/close_menu_id"

12 android:icon="@drawable/btn_close"

13 android:title="@string/close"

14 chrome:showAsAction="ifRoom" />

15 </group>

16 <group

17 android:id="@+id/photo_picker_selection_mode_menu_group"

18 android:visible="false" >

19 <item

20 android:id="@+id/selection_mode_done_menu_id"

21 android:title="@string/done"

22 chrome:showAsAction="always" />

23 </group>

24 </menu>

OLD	NEW