Chromium Code Reviews
Help | Chromium Project | Sign in
(688)

Issue 2874002: Change the Windows CertDatabase behaviour to match Mac and NSS behaviour, whe... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by rsleevi-old
Modified:
2 years, 11 months ago
Reviewers:
wtc, David Benjamin
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org, John Grabowski, cbentzel+watch_chromium.org, darin-cc_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Change Windows' application/x-x509-user-cert handling to allow any certificate that has a private key, regardless of where it was generated, rather than restricting it to keys generated via <keygen> in the current browsing session.

BUG=148
TEST=None
R=wtc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50695

Patch Set 1 #

Patch Set 2 : Actually delete keygen_handler this time #

Total comments: 3

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -319 lines) Lint Patch
M net/base/cert_database_win.cc View 1 2 2 chunks +3 lines, -69 lines 0 comments 0 errors Download
M net/base/keygen_handler.h View 1 2 2 chunks +0 lines, -52 lines 0 comments 0 errors Download
D net/base/keygen_handler.cc View 1 chunk +0 lines, -36 lines 0 comments 0 errors Download
M net/base/keygen_handler_mac.cc View 1 chunk +0 lines, -6 lines 0 comments 0 errors Download
M net/base/keygen_handler_nss.cc View 1 chunk +0 lines, -5 lines 0 comments 0 errors Download
M net/base/keygen_handler_unittest.cc View 2 chunks +0 lines, -42 lines 0 comments 0 errors Download
M net/base/keygen_handler_win.cc View 4 chunks +0 lines, -95 lines 0 comments 0 errors Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M net/third_party/mozilla_security_manager/nsKeygenHandler.cpp View 1 2 3 chunks +0 lines, -13 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
rsleevi-old
This is split from http://codereview.chromium.org/2668005, to make reviewing easier. There is a performance trade-off here, ...
3 years, 10 months ago #1
wtc
3 years, 10 months ago #2
LGTM!

David Benjamin will work on trying to not import unsolicited
application/x-x509-user-cert responses.  So he will be modifying this
code soon.

Please add
    R=wtc
    BUG=148
to the Description of the CL.

http://codereview.chromium.org/2874002/diff/14003/16001
File net/base/cert_database_win.cc (right):

http://codereview.chromium.org/2874002/diff/14003/16001#newcode13
net/base/cert_database_win.cc:13: #include "net/base/keygen_handler.h"
Remove "base/logging.h".
Remove "base/string_util.h".
Remove "net/base/keygen_handler.h".

http://codereview.chromium.org/2874002/diff/14003/16003
File net/base/keygen_handler.h (right):

http://codereview.chromium.org/2874002/diff/14003/16003#newcode8
net/base/keygen_handler.h:8: #include <map>
Remove <map>.

http://codereview.chromium.org/2874002/diff/14003/16009
File net/third_party/mozilla_security_manager/nsKeygenHandler.cpp (right):

http://codereview.chromium.org/2874002/diff/14003/16009#newcode53
net/third_party/mozilla_security_manager/nsKeygenHandler.cpp:53: #include
"net/base/keygen_handler.h"
Remove "net/base/keygen_handler.h".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6