Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc

Issue 2873963003: Add an async ReadInitialHeaders method to QuicChromiumClientStream::Handle (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
diff --git a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
index deb0805155b2de5d22fc1dcf5b43a8c35691fb23..cdd79feb1f0d080f9d4c1c8171a27e284e7d3aa0 100644
--- a/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
+++ b/net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc
@@ -296,10 +296,13 @@ class DeleteStreamDelegate : public TestDelegateBase {
~DeleteStreamDelegate() override {}
void OnHeadersReceived(const SpdyHeaderBlock& response_headers) override {
+ // Make a copy of |response_headers| before the stream is deleted, since
+ // the headers are owned by the stream.
+ SpdyHeaderBlock headers_copy = response_headers.Clone();
if (phase_ == ON_HEADERS_RECEIVED) {
DeleteStream();
}
- TestDelegateBase::OnHeadersReceived(response_headers);
+ TestDelegateBase::OnHeadersReceived(headers_copy);
}
void OnDataSent() override { NOTREACHED(); }
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.cc ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698