chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java - Issue 2873943005: Add additional checks for comment signed WebAPKs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java

Issue 2873943005: Add additional checks for comment signed WebAPKs. (Closed)

Patch Set: Fix incorrect conditional. Add more apk test files. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java

diff --git a/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java b/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java

index 83b70614789c345f849441779ff2f25da67dfdd9..30c2b9aaa8c5f2388413b728650332f1185de611 100644

--- a/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java

+++ b/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java

@@ -205,7 +205,7 @@ public class WebApkValidatorTest {

@Test

public void testIsValidWebApkCommentSigned() {

- String[] filenames = {"example.apk", "java-example.apk"};

+ String[] filenames = {"example.apk", "java-example.apk", "v2-signed-ok.apk"};

String packageName = "com.webapk.a9c419502bb98fcb7";

Signature[] signature = new Signature[] {new Signature(SIGNATURE_1)};

@@ -225,11 +225,11 @@ public class WebApkValidatorTest {

@Test

public void testIsValidWebApkCommentSignedFailures() {

String[] filenames = {

- "bad-sig.apk", "bad-utf8-fname.apk", "empty.apk", "extra-len-too-large.apk",

- "fcomment-too-large.apk", "no-cd.apk", "no-comment.apk", "no-eocd.apk",

- "no-lfh.apk", "not-an.apk", "too-many-metainf.apk", "truncated.apk", "zeros.apk",

- "zeros-at-end.apk", "block-before-first.apk", "block-at-end.apk",

- "block-before-eocd.apk", "block-before-cd.apk",

+ "bad-sig.apk", "bad-utf8-fname.apk", "empty.apk", "extra-field-too-large.apk",

+ "extra-len-too-large.apk", "fcomment-too-large.apk", "no-cd.apk", "no-comment.apk",

+ "no-eocd.apk", "no-lfh.apk", "not-an.apk", "too-many-metainf.apk", "truncated.apk",

+ "zeros.apk", "zeros-at-end.apk", "block-before-first.apk", "block-at-end.apk",

+ "block-before-eocd.apk", "block-before-cd.apk", "v2-signed-too-large.apk",

};

String packageName = "com.webapk.a9c419502bb98fcb7";

Signature[] signature = new Signature[] {new Signature(SIGNATURE_1)};

« no previous file with comments | « no previous file | chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java » ('j') | no next file with comments »