Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h

Issue 2873943002: Ensure original parser context is used when parsing resolved var() references (Closed)
Patch Set: g cl set-commit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h b/third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h
index f8a21aeafbd7a771c82091d7e92285ab23668aa5..2e3ec4f36f63ab7bcd8b07994555c643711788e8 100644
--- a/third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h
+++ b/third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h
@@ -7,17 +7,22 @@
#include "core/css/CSSValue.h"
#include "core/css/CSSVariableData.h"
+#include "core/css/parser/CSSParserContext.h"
#include "platform/wtf/RefPtr.h"
namespace blink {
class CSSVariableReferenceValue : public CSSValue {
public:
- static CSSVariableReferenceValue* Create(PassRefPtr<CSSVariableData> data) {
- return new CSSVariableReferenceValue(std::move(data));
+ static CSSVariableReferenceValue* Create(PassRefPtr<CSSVariableData> data,
+ const CSSParserContext& context) {
+ return new CSSVariableReferenceValue(std::move(data), context);
}
CSSVariableData* VariableDataValue() const { return data_.Get(); }
+ const CSSParserContext* ParserContext() const {
+ return parser_context_.Get();
+ }
bool Equals(const CSSVariableReferenceValue& other) const {
return data_ == other.data_;
@@ -27,10 +32,16 @@ class CSSVariableReferenceValue : public CSSValue {
DECLARE_TRACE_AFTER_DISPATCH();
private:
- CSSVariableReferenceValue(PassRefPtr<CSSVariableData> data)
- : CSSValue(kVariableReferenceClass), data_(std::move(data)) {}
+ CSSVariableReferenceValue(PassRefPtr<CSSVariableData> data,
+ const CSSParserContext& context)
+ : CSSValue(kVariableReferenceClass),
+ data_(std::move(data)),
+ parser_context_(context) {
+ DCHECK(parser_context_);
+ }
RefPtr<CSSVariableData> data_;
+ Member<const CSSParserContext> parser_context_;
};
DEFINE_CSS_VALUE_TYPE_CASTS(CSSVariableReferenceValue,

Powered by Google App Engine
This is Rietveld 408576698