Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/resources/settings/android_apps_page/android_apps_page.js

Issue 2873853002: arc: Handle ARC events in MD Settings (Closed)
Patch Set: fix annotations Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/android_apps_page/android_apps_page.js
diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
index 861731780652ab51607d5907c609012ddb6e61da..baa88b61279c66dee9a39b666b0ff0f5982f50e1 100644
--- a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
@@ -55,6 +55,10 @@ Polymer({
*/
androidAppsInfoUpdate_: function(info) {
this.androidAppsInfo_ = info;
+ if (!this.androidAppsInfo_.playStoreEnabled) {
+ if (settings.getCurrentRoute() == settings.Route.ANDROID_APPS_DETAILS)
stevenjb 2017/05/10 16:47:03 Combine these ifs.
khmel 2017/05/10 21:48:12 Done.
+ settings.navigateTo(settings.Route.ANDROID_APPS);
stevenjb 2017/05/10 16:47:03 nit: settings.navigateToPreviousRoute();
khmel 2017/05/10 21:48:12 Done. My concern was what if user directly opens A
stevenjb 2017/05/10 22:35:44 In that case we would just return to the main Sett
+ }
},
/**
@@ -68,7 +72,7 @@ Polymer({
/** @private */
onSubpageTap_: function() {
- if (this.androidAppsInfo_.appReady)
+ if (this.androidAppsInfo_.playStoreEnabled)
settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);
},
});

Powered by Google App Engine
This is Rietveld 408576698