Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4331)

Unified Diff: chrome/browser/resources/settings/android_apps_page/android_apps_page.js

Issue 2873853002: arc: Handle ARC events in MD Settings (Closed)
Patch Set: fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/android_apps_page/android_apps_page.js
diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
index 861731780652ab51607d5907c609012ddb6e61da..e5f9cba60d51c94fd615b5d4ca179dbce789e293 100644
--- a/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
@@ -38,17 +38,26 @@ Polymer({
/** @private {?settings.AndroidAppsBrowserProxy} */
browserProxy_: null,
+ /** @private {?WebUIListener} */
+ listener_: null,
+
/** @override */
created: function() {
this.browserProxy_ = settings.AndroidAppsBrowserProxyImpl.getInstance();
},
/** @override */
- ready: function() {
- cr.addWebUIListener(
+ attached: function() {
+ this.listener_ = cr.addWebUIListener(
'android-apps-info-update', this.androidAppsInfoUpdate_.bind(this));
this.browserProxy_.requestAndroidAppsInfo();
},
+
+ /** @override */
+ detached: function() {
+ cr.removeWebUIListener(this.listener_);
+ },
+
/**
* @param {AndroidAppsInfo} info
* @private
@@ -68,7 +77,7 @@ Polymer({
/** @private */
onSubpageTap_: function() {
- if (this.androidAppsInfo_.appReady)
+ if (this.androidAppsInfo_.playStoreEnabled)
settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);
},
});

Powered by Google App Engine
This is Rietveld 408576698