arc: Handle ARC events in MD Settings

chrome/test/data/webui/settings/android_apps_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {settings.AndroidAppsBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 function TestAndroidAppsBrowserProxy() {
   settings.TestBrowserProxy.call(this, [
     'requestAndroidAppsInfo',
     'showAndroidAppsSettings',
   ]);
 }
 
 TestAndroidAppsBrowserProxy.prototype = {
   __proto__: settings.TestBrowserProxy.prototype,
 
   /** @override */
   requestAndroidAppsInfo: function() {
     this.methodCalled('requestAndroidAppsInfo');
-    cr.webUIListenerCallback('android-apps-info-update', {appReady: false});
+    this.setAndroidAppsState(false, false);
   },
 
   /** override */
   showAndroidAppsSettings: function(keyboardAction) {
     this.methodCalled('showAndroidAppsSettings');
   },
 
-  setAppReady: function(ready) {
+  setAndroidAppsState: function(playStoreEnabled, settingsAppAvailable) {
     // We need to make sure to pass a new object here, otherwise the property
     // change event may not get fired in the listener.
-    cr.webUIListenerCallback('android-apps-info-update', {appReady: ready});
+    var appsInfo = {
+      playStoreEnabled: playStoreEnabled,
+      settingsAppAvailable: settingsAppAvailable,
+    };
+    cr.webUIListenerCallback('android-apps-info-update', appsInfo);
   },
 };
 
 /** @type {?SettingsAndroidAppsPageElement} */
 var androidAppsPage = null;
 
 /** @type {?TestAndroidAppsBrowserProxy} */
 var androidAppsBrowserProxy = null;
 
 suite('AndroidAppsPageTests', function() {
@@ skipping 10 matching lines @@
     androidAppsPage.remove();
   });
 
   suite('Main Page', function() {
     setup(function() {
       androidAppsPage.prefs = {arc: {enabled: {value: false}}};
       Polymer.dom.flush();
 
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(false);
+            androidAppsBrowserProxy.setAndroidAppsState(false, false);
           });
     });
 
     test('Enable', function() {
       var button = androidAppsPage.$$('#enable');
       assertTrue(!!button);
       assertFalse(!!androidAppsPage.$$('.subpage-arrow'));
 
       MockInteractions.tap(button);
       Polymer.dom.flush();
       assertTrue(androidAppsPage.prefs.arc.enabled.value);
 
-      androidAppsBrowserProxy.setAppReady(true);
+      androidAppsBrowserProxy.setAndroidAppsState(true, false);
       Polymer.dom.flush();
       assertTrue(!!androidAppsPage.$$('.subpage-arrow'));
     });
   });
 
   suite('SubPage', function() {
     var subpage;
+    var initialHRef;
+
+    /**
+     * Returns a new promise that resolves after a window 'popstate' event.
+     * @return {!Promise}
+     */
+    function whenPopState() {
+      var promise = new Promise(function(resolve) {
+        window.addEventListener('popstate', function callback() {
+          window.removeEventListener('popstate', callback);
+          resolve();
+        });
+      });
+      return promise;
+    }
+
+    /**
+     * Returns a new promise that resolves after a node becomes available for
+     * interaction.
+     * @return {!Promise}
+     */
+    function whenNodeCanInteract(node) {
+      var promise = new Promise(function(resolve) {
+        var checkNode = function() {
+          if (window.getComputedStyle(node)['pointer-events'] != 'none')
+            resolve();
+          else
+            setTimeout(checkNode, 1);
+        }
+        checkNode();
+      });
+      return promise;
+    }
 
     setup(function() {
       androidAppsPage.prefs = {arc: {enabled: {value: true}}};
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(true);
+            initialHRef = window.location.href;
+            androidAppsBrowserProxy.setAndroidAppsState(true, false);
             MockInteractions.tap(androidAppsPage.$$('#android-apps'));
             Polymer.dom.flush();
             subpage = androidAppsPage.$$('settings-android-apps-subpage');
             assertTrue(!!subpage);
           });
     });
 
+    teardown(function() {
+      if (settings.getCurrentRoute() == settings.Route.ANDROID_APPS_DETAILS) {

[khmel, 2017/05/10 21:48:13]

Need to go back after test. Otherwise multiple setup calls stack several
app_detailed locations and it is impossible to validate that navigation actually
happens.

[stevenjb, 2017/05/10 22:35:44]

Ugh. Can we just navigate directly to ANDROID_APPS_PAGE in setup instead?

[khmel, 2017/05/11 00:10:30]

Yes, but this would increase history stack.

+        settings.navigateToPreviousRoute();
+        return whenPopState().then(function() {});
+      }
+    });
+
     test('Sanity', function() {
+      assertTrue(!!subpage.$$('#remove'));
       assertTrue(!!subpage.$$('#manageApps'));
-      assertTrue(!!subpage.$$('#remove'));
+    });
+
+    test('ManageAppsUpdate', function() {
+      var manageApps = subpage.$$('#manageApps');
+      assertTrue(manageApps.hidden);
+      androidAppsBrowserProxy.setAndroidAppsState(true, true);
+      Polymer.dom.flush();
+      assertFalse(manageApps.hidden);
+      androidAppsBrowserProxy.setAndroidAppsState(true, false);
+      Polymer.dom.flush();
+      assertTrue(manageApps.hidden);
     });
 
     test('Disable', function() {
       var dialog = subpage.$$('#confirmDisableDialog');
       assertTrue(!!dialog);
       assertFalse(dialog.open);
 
       var remove = subpage.$$('#remove');
       assertTrue(!!remove);
-      MockInteractions.tap(remove);
 
+      // remove button is not always visible immediately after dom flush. This
+      // leads to tap ignoring and test failure. Simulate tap asynchronously.
+      return whenNodeCanInteract(remove).then(function() {

[khmel, 2017/05/10 21:48:13]

Well, Polymer.async did not help. also SetTimeot 0 does not work always. I found
only this way to wait until remove button is active.

[stevenjb, 2017/05/10 22:35:44]

Ugh. Timeout loops like that tend to be fragile in tests.

This is a lot of subtle / complex change. I would want to bring in some folks
more familiar with our test infrastructure rather than adding yet another
complicated solution.

I have worked around issues with 'tap' before by calling the tap handler
directly. Can we try doing that instead?

[khmel, 2017/05/11 00:10:30]

What is your suggestion?
.click is not visible. 
.pressAndReleaseKeyOn is async and also required waiting.

+        MockInteractions.tap(remove);
+        Polymer.dom.flush();
+        assertTrue(dialog.open);
+      });
+    });
+
+    test('HideOnDisable', function() {
+      assertEquals(settings.getCurrentRoute(),
+                   settings.Route.ANDROID_APPS_DETAILS);
+      androidAppsBrowserProxy.setAndroidAppsState(false, false);
       Polymer.dom.flush();
-      assertTrue(dialog.open);
+      return whenPopState().then(function() {
+        assertNotEquals(settings.getCurrentRoute(),
+            settings.Route.ANDROID_APPS_DETAILS);
+        assertEquals(initialHRef, window.location.href);
+      });
     });
   });
 
   suite('Enforced', function() {
     var subpage;
 
     setup(function() {
       androidAppsPage.prefs = {
         arc: {
           enabled: {
             value: true,
             enforcement: chrome.settingsPrivate.Enforcement.ENFORCED
           }
         }
       };
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(true);
+            androidAppsBrowserProxy.setAndroidAppsState(true, true);
             MockInteractions.tap(androidAppsPage.$$('#android-apps'));
             Polymer.dom.flush();
             subpage = androidAppsPage.$$('settings-android-apps-subpage');
             assertTrue(!!subpage);
           });
     });
 
     test('Sanity', function() {
       Polymer.dom.flush();
       assertTrue(!!subpage.$$('#manageApps'));
       assertFalse(!!subpage.$$('#remove'));
     });
   });
 });