arc: Handle ARC events in MD Settings

chrome/test/data/webui/settings/android_apps_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {settings.AndroidAppsBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 function TestAndroidAppsBrowserProxy() {
   settings.TestBrowserProxy.call(this, [
     'requestAndroidAppsInfo',
     'showAndroidAppsSettings',
   ]);
 }
 
 TestAndroidAppsBrowserProxy.prototype = {
   __proto__: settings.TestBrowserProxy.prototype,
 
   /** @override */
   requestAndroidAppsInfo: function() {
     this.methodCalled('requestAndroidAppsInfo');
-    cr.webUIListenerCallback('android-apps-info-update', {appReady: false});
+    this.setAndroidAppsState(false, false);
   },
 
   /** override */
   showAndroidAppsSettings: function(keyboardAction) {
     this.methodCalled('showAndroidAppsSettings');
   },
 
-  setAppReady: function(ready) {
+  setAndroidAppsState: function(playStoreEnabled, appSettingsAvailable) {
     // We need to make sure to pass a new object here, otherwise the property
     // change event may not get fired in the listener.
-    cr.webUIListenerCallback('android-apps-info-update', {appReady: ready});
+    var appsInfo = {};
+    appsInfo.playStoreEnabled = playStoreEnabled;
+    appsInfo.appSettingsAvailable = appSettingsAvailable;

[stevenjb, 2017/05/10 16:47:03]

nit:
var appsInfo = {
  playStoreEnabled: playStoreEnabled,
  appSettingsAvailable: appSettingsAvailable,
};

[khmel, 2017/05/10 21:48:12]

Done.

+    cr.webUIListenerCallback('android-apps-info-update', appsInfo);
   },
 };
 
 /** @type {?SettingsAndroidAppsPageElement} */
 var androidAppsPage = null;
 
 /** @type {?TestAndroidAppsBrowserProxy} */
 var androidAppsBrowserProxy = null;
 
 suite('AndroidAppsPageTests', function() {
@@ skipping 10 matching lines @@
     androidAppsPage.remove();
   });
 
   suite('Main Page', function() {
     setup(function() {
       androidAppsPage.prefs = {arc: {enabled: {value: false}}};
       Polymer.dom.flush();
 
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(false);
+            androidAppsBrowserProxy.setAndroidAppsState(false, false);
           });
     });
 
     test('Enable', function() {
       var button = androidAppsPage.$$('#enable');
       assertTrue(!!button);
       assertFalse(!!androidAppsPage.$$('.subpage-arrow'));
 
       MockInteractions.tap(button);
       Polymer.dom.flush();
       assertTrue(androidAppsPage.prefs.arc.enabled.value);
 
-      androidAppsBrowserProxy.setAppReady(true);
+      androidAppsBrowserProxy.setAndroidAppsState(true, false);
       Polymer.dom.flush();
       assertTrue(!!androidAppsPage.$$('.subpage-arrow'));
     });
   });
 
   suite('SubPage', function() {
     var subpage;
 
     setup(function() {
       androidAppsPage.prefs = {arc: {enabled: {value: true}}};
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(true);
+            androidAppsBrowserProxy.setAndroidAppsState(true, false);
             MockInteractions.tap(androidAppsPage.$$('#android-apps'));
             Polymer.dom.flush();
             subpage = androidAppsPage.$$('settings-android-apps-subpage');
             assertTrue(!!subpage);
           });
     });
 
     test('Sanity', function() {
+      assertTrue(!!subpage.$$('#remove'));
       assertTrue(!!subpage.$$('#manageApps'));
-      assertTrue(!!subpage.$$('#remove'));
+    });
+
+    test('ManageAppsUpdate', function() {
+      var manageApps = subpage.$$('#manageApps');
+      assertTrue(manageApps.hidden);
+      androidAppsBrowserProxy.setAndroidAppsState(true, true);
+      Polymer.dom.flush();
+      assertFalse(manageApps.hidden);
+      androidAppsBrowserProxy.setAndroidAppsState(true, false);
+      Polymer.dom.flush();
+      assertTrue(manageApps.hidden);
     });
 
     test('Disable', function() {
       var dialog = subpage.$$('#confirmDisableDialog');
       assertTrue(!!dialog);
       assertFalse(dialog.open);
 
       var remove = subpage.$$('#remove');
       assertTrue(!!remove);
-      MockInteractions.tap(remove);
 
+      // remove button is not always visible immediately after dom flush. This
+      // leads to tap ignoring and test failure. Simulate tap asynchronously.

[stevenjb, 2017/05/10 16:47:03]

Instead of using setTimeout, try this:

return Polymer.Base.async(function() {
  MockInteractions.tap(remove);
  Polymer.dom.flush();
  ssertTrue(dialog.open);
});

[khmel, 2017/05/10 21:48:12]

Nice, thanks for sharing this info. I tried to find something similar . However
did not help :(.
Tap simulation ignored:
  function tap(node, options) {
    // Respect nodes that are disabled in the UI.
    if (window.getComputedStyle(node)['pointer-events'] === 'none')
      return;

+      return new Promise(function(resolve, reject) {
+        var validateDialog = function() {
+          MockInteractions.tap(remove);
+          Polymer.dom.flush();
+          assertTrue(dialog.open);
+          resolve();
+        }
+        setTimeout(validateDialog, 0)
+      });
+    });
+
+    test('HideOnDisable', function() {
+      assertEquals(settings.getCurrentRoute(),
+                   settings.Route.ANDROID_APPS_DETAILS);
+      androidAppsBrowserProxy.setAndroidAppsState(false, false);
       Polymer.dom.flush();
-      assertTrue(dialog.open);
+      assertEquals(settings.getCurrentRoute(), settings.Route.ANDROID_APPS);
     });
+
   });
 
   suite('Enforced', function() {
     var subpage;
 
     setup(function() {
       androidAppsPage.prefs = {
         arc: {
           enabled: {
             value: true,
             enforcement: chrome.settingsPrivate.Enforcement.ENFORCED
           }
         }
       };
       return androidAppsBrowserProxy.whenCalled('requestAndroidAppsInfo')
           .then(function() {
-            androidAppsBrowserProxy.setAppReady(true);
+            androidAppsBrowserProxy.setAndroidAppsState(true, true);
             MockInteractions.tap(androidAppsPage.$$('#android-apps'));
             Polymer.dom.flush();
             subpage = androidAppsPage.$$('settings-android-apps-subpage');
             assertTrue(!!subpage);
           });
     });
 
     test('Sanity', function() {
       Polymer.dom.flush();
       assertTrue(!!subpage.$$('#manageApps'));
       assertFalse(!!subpage.$$('#remove'));
     });
   });
 });