arc: Handle ARC events in MD Settings

chrome/browser/resources/settings/android_apps_page/android_apps_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'android-apps-page' is the settings page for enabling android apps.
  */
 
 Polymer({
@@ skipping 37 matching lines @@
     cr.addWebUIListener(
         'android-apps-info-update', this.androidAppsInfoUpdate_.bind(this));
     this.browserProxy_.requestAndroidAppsInfo();
   },
   /**
    * @param {AndroidAppsInfo} info
    * @private
    */
   androidAppsInfoUpdate_: function(info) {
     this.androidAppsInfo_ = info;
+    if (!this.androidAppsInfo_.playStoreEnabled) {
+      if (settings.getCurrentRoute() == settings.Route.ANDROID_APPS_DETAILS)

[stevenjb, 2017/05/10 16:47:03]

Combine these ifs.

[khmel, 2017/05/10 21:48:12]

Done.

+        settings.navigateTo(settings.Route.ANDROID_APPS);

[stevenjb, 2017/05/10 16:47:03]

nit: settings.navigateToPreviousRoute();

[khmel, 2017/05/10 21:48:12]

Done.
My concern was what if user directly opens ANDROID_APPS_DETAILS. IIUC this would
be possible to do by providing direct URL in settings.

[stevenjb, 2017/05/10 22:35:44]

In that case we would just return to the main Settings page, which is fine, but
in general using navigateToPreviousRoute() is a bit more robust.

+    }
   },
 
   /**
    * @param {Event} event
    * @private
    */
   onEnableTap_: function(event) {
     this.setPrefValue('arc.enabled', true);
     event.stopPropagation();
   },
 
   /** @private */
   onSubpageTap_: function() {
-    if (this.androidAppsInfo_.appReady)
+    if (this.androidAppsInfo_.playStoreEnabled)
       settings.navigateTo(settings.Route.ANDROID_APPS_DETAILS);
   },
 });