arc: Handle ARC events in MD Settings

chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'android-apps-subpage' is the settings subpage for managing android apps.
  */
 
 Polymer({
   is: 'settings-android-apps-subpage',
 
   behaviors: [I18nBehavior, PrefsBehavior],
 
   properties: {
     /** Preferences state. */
     prefs: Object,
 
     /** @private {!AndroidAppsInfo|undefined} */
     androidAppsInfo: Object,

[stevenjb, 2017/05/11 17:46:54]

androidAppsInfo: {
  type: Object,
  observer: 'onAndroidAppsInfoUpdate_',
},

[khmel, 2017/05/11 19:09:46]

Nice, was not aware about this possibility. Done.

 
     /** @private */
     dialogBody_: {
       type: String,
       value: function() {
         return this.i18nAdvanced(
             'androidAppsDisableDialogMessage',
             {substitutions: [], tags: ['br']});
       }
     }
   },
 
   /** @private {?settings.AndroidAppsBrowserProxy} */
   browserProxy_: null,
 
   /** @override */
   created: function() {
     this.browserProxy_ = settings.AndroidAppsBrowserProxyImpl.getInstance();
   },
 
+  /** @override */
+  ready: function() {
+    cr.addWebUIListener(
+        'android-apps-info-update', this.androidAppsInfoUpdate_.bind(this));
+  },

[stevenjb, 2017/05/11 17:46:54]

No need for this.

[khmel, 2017/05/11 19:09:46]

Done.

+
+  /**
+   * @param {AndroidAppsInfo} info
+   * @private
+   */
+  androidAppsInfoUpdate_: function(info) {

[stevenjb, 2017/05/11 17:46:54]

onAndroidAppsInfoUpdate_: function() {

[khmel, 2017/05/11 19:09:46]

Done. However I have to discard root app element from testing to avoid problem
when this multiple observers from android_apps_page change this info and as
result multiple back requests are issued which breaks the test.

+    if (!info.playStoreEnabled &&

[stevenjb, 2017/05/11 17:46:54]

if (this.androidAppsInfo.playStoreEnabled &&

[khmel, 2017/05/11 19:09:46]

Done.

+        settings.getCurrentRoute() == settings.Route.ANDROID_APPS_DETAILS) {

[stevenjb, 2017/05/11 17:46:54]

This test should no longer be necessary since the subpage will be templated out
(i.e. will be removed) when the route is not ANDROID_APPS_DETAILS.

[khmel, 2017/05/11 19:09:46]

Good point, right.

+      settings.navigateToPreviousRoute();
+    }
+  },
+
   /**
    * @param {Event} event
    * @private
    */
   onManageAndroidAppsKeydown_: function(event) {
     if (event.key != 'Enter' && event.key != ' ')
       return;
     this.browserProxy_.showAndroidAppsSettings(true /** keyboardAction */);
     event.stopPropagation();
   },
@@ skipping 21 matching lines @@
     this.$.confirmDisableDialog.showModal();
   },
 
   /**
    * Handles the shared proxy confirmation dialog 'Confirm' button.
    * @private
    */
   onConfirmDisableDialogConfirm_: function() {
     this.setPrefValue('arc.enabled', false);
     this.$.confirmDisableDialog.close();
     settings.navigateToPreviousRoute();

[stevenjb, 2017/05/11 17:46:54]

This should already be navigate back when we disable arc, which is why I'm not
sure when/why the code above is needed.

[khmel, 2017/05/11 19:09:46]

This goes back only in case when ARC is disabled from settings, but not from
other points. For example when ARC OptIn page is closed.

[stevenjb, 2017/05/11 19:40:43]

Ah, OK, that is the use case I was missing.

   },
 
   /**
    * Handles the shared proxy confirmation dialog 'Cancel' button or a cancel
    * event.
    * @private
    */
   onConfirmDisableDialogCancel_: function() {
     this.$.confirmDisableDialog.close();
   },
 
   /** @private */
   onConfirmDisableDialogClose_: function() {
     cr.ui.focusWithoutInk(assert(this.$$('#remove button')));
   },
 });