Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2873843002: Support autopresenting WebVr content. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 27c46ed667dec4df0a9416d31ac048f754bda2f8..6a89e97ac728a1e6ebbf38e3ed492b53370d950d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -643,6 +643,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mTabModelsInitialized = true;
}
+ /**
+ * @return Whether this activity can automatically present WebVr content in fullscreen
+ * binocular rendering mode. Normally, WebVr presentation is user initiated.
+ */
+ public boolean canAutopresentVr() {
mthiesse 2017/05/10 14:52:14 I don't know what Ted's opinion on this is, but so
Ted C 2017/05/11 00:05:03 Adding this to VrShellDelegate sgtm and seems cons
ymalik 2017/05/11 03:32:27 Done.
+ return false;
+ }
+
/**
* @return The {@link TabModelSelector} owned by this {@link ChromeActivity}.
*/
@@ -792,6 +800,8 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (mDeferredStartupQueued || getActivityTab() == null || !getActivityTab().isLoading()) {
postDeferredStartupIfNeeded();
}
+
+ VrShellDelegate.onNewIntent(this, getIntent());
mthiesse 2017/05/10 14:52:14 What happens when you use the task switcher to swi
Ted C 2017/05/11 00:05:03 Yes it would, why not have this in onNewIntentWith
ymalik 2017/05/11 03:32:27 Thanks for the tip. Done.
}
@Override

Powered by Google App Engine
This is Rietveld 408576698