Support autopresenting WebVr content.

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 723 matching lines @@
      * @return Whether contextual search is allowed for this activity or not.
      */
     protected boolean isContextualSearchAllowed() {
         return true;
     }
 
     @Override
     public void initializeState() {
         super.initializeState();
 
+        if (getSavedInstanceState() == null && getIntent() != null) {
+            // We send this intent so that we can enter WebVr presentation mode if needed.

[mthiesse, 2017/05/11 17:29:15]

Add comment on why you don't mark the intent as handled here (and below)?

[Ted C, 2017/05/11 18:10:38]

The problem is ChromeTabbedActivity creates the tabs after this point, so if you
try to do anything with the current tab you might get some weird behavior.

For now until we start doing this for other activity types (which I don't see a
path where that would work), I would actually just add this in
ChromeTabbedActivity here:

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

processUrlViewIntent is done when we are creating a new tab or doing something
on them.  It handles the saved instance state stuff for you, so I think that is
actually cleaner.

[ymalik, 2017/05/11 21:17:52]

Ah I see. Okay moved it to processUrlViewIntent. This function is also called
from onNewNativeIntent (via mIntentHandler.onNewIntent), so we would only need
it in one place which is much cleaner (with the caveat that we're CCT won't get
this, but we're not supporting CCT anyway).

+            VrShellDelegate.onNewIntent(this, getIntent());
+        }
+
         IntentHandler.setTestIntentsEnabled(
                 CommandLine.getInstance().hasSwitch(ContentSwitches.ENABLE_TEST_INTENTS));
         mIntentHandler = new IntentHandler(createIntentHandlerDelegate(), getPackageName());
     }
 
     @Override
     public void initializeCompositor() {
         TraceEvent.begin("ChromeActivity:CompositorInitialization");
         super.initializeCompositor();
 
@@ skipping 155 matching lines @@
     }
 
     @Override
     public void onNewIntentWithNative(Intent intent) {
         VideoPersister.getInstance().cleanup(this);
 
         super.onNewIntentWithNative(intent);
         if (mIntentHandler.shouldIgnoreIntent(intent)) return;
 
         mIntentHandler.onNewIntent(intent);
+        VrShellDelegate.onNewIntent(this, intent);
     }
 
     /**
      * @return Whether the given activity contains a CustomTab.
      */
     public boolean isCustomTab() {
         return false;
     }
 
     /**
@@ skipping 1268 matching lines @@
     public void onExitVr() {}
 
     /**
      * Whether this Activity supports moving a {@link Tab} to the
      * {@link FullscreenWebContentsActivity} when it enters fullscreen.
      */
     public boolean supportsFullscreenActivity() {
         return false;
     }
 }