Support autopresenting WebVr content.

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 626 matching lines @@
         };
 
         if (mAssistStatusHandler != null) {
             mAssistStatusHandler.setTabModelSelector(mTabModelSelector);
         }
 
         mTabModelsInitialized = true;
     }
 
     /**
+     * @return Whether this activity can automatically present WebVr content in fullscreen
+     *         binocular rendering mode. Normally, WebVr presentation is user initiated.
+     */
+    public boolean canAutopresentVr() {

[mthiesse, 2017/05/10 14:52:14]

I don't know what Ted's opinion on this is, but so far we've been avoiding
making these activities aware of VR where possible.

See VrShellDelegate#activitySupportsVrBrowsing for how I've been doing similar
things so far. You could add a VrShellDelegate#activitySupportsWebVrAutopresent.

[Ted C, 2017/05/11 00:05:03]

Adding this to VrShellDelegate sgtm and seems consistent.

[ymalik, 2017/05/11 03:32:27]

Done.

+        return false;
+    }
+
+    /**
      * @return The {@link TabModelSelector} owned by this {@link ChromeActivity}.
      */
     protected abstract TabModelSelector createTabModelSelector();
 
     /**
      * @return The {@link org.chromium.chrome.browser.tabmodel.TabCreatorManager.TabCreator}s owned
      *         by this {@link ChromeActivity}.  The first item in the Pair is the normal model tab
      *         creator, and the second is the tab creator for incognito tabs.
      */
     protected abstract Pair<? extends TabCreator, ? extends TabCreator> createTabCreators();
@@ skipping 128 matching lines @@
             ContextReporter.reportStatus(ContextReporter.STATUS_GSA_NOT_AVAILABLE);
         }
 
         // postDeferredStartupIfNeeded() is called in TabModelSelectorTabObsever#onLoadStopped(),
         // #onPageLoadFinished() and #onCrash(). If we are not actively loading a tab (e.g.
         // in Android N multi-instance, which is created by re-parenting an existing tab),
         // ensure onDeferredStartup() gets called by calling postDeferredStartupIfNeeded() here.
         if (mDeferredStartupQueued || getActivityTab() == null || !getActivityTab().isLoading()) {
             postDeferredStartupIfNeeded();
         }
+
+        VrShellDelegate.onNewIntent(this, getIntent());

[mthiesse, 2017/05/10 14:52:14]

What happens when you use the task switcher to switch away from chrome, then
back to chrome? Won't this read the same intent and try to autopresent again
when you resume Chrome?

[Ted C, 2017/05/11 00:05:03]

Yes it would, why not have this in onNewIntentWithNative?  The gotcha is that
isn't
called for the initial run, so you would need to add any additional logic in
this "general"
area.

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

[ymalik, 2017/05/11 03:32:27]

Thanks for the tip. Done.

     }
 
     @Override
     public void onWindowFocusChanged(boolean hasFocus) {
         super.onWindowFocusChanged(hasFocus);
 
         maybeRemoveWindowBackground();
 
         Tab tab = getActivityTab();
         if (tab == null) return;
@@ skipping 1392 matching lines @@
     public void onExitVr() {}
 
     /**
      * Whether this Activity supports moving a {@link Tab} to the
      * {@link FullscreenWebContentsActivity} when it enters fullscreen.
      */
     public boolean supportsFullscreenActivity() {
         return false;
     }
 }