Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 287383004: Use arrow operator for iterators instead of asterisk-parentheses-dot (Closed)

Created:
6 years, 7 months ago by Erik Corry
Modified:
6 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, fs, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, vsevik+blink_chromium.org, caseq+blink_chromium.org, krit, malch+blink_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., rwlbuis, kenneth.christiansen, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, Stephen Chennney, blink-reviews-rendering, kouhei+svg_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), sergeyv+blink_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/FormController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FloatingObjects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 17 chunks +17 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFilterElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Erik Corry
6 years, 7 months ago (2014-05-19 12:57:48 UTC) #1
zerny-chromium
LGTM!
6 years, 7 months ago (2014-05-19 12:59:06 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-19 13:00:32 UTC) #3
Mikhail
lgtm
6 years, 7 months ago (2014-05-19 13:01:29 UTC) #4
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 7 months ago (2014-05-19 13:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/287383004/1
6 years, 7 months ago (2014-05-19 13:01:58 UTC) #6
haraken
LGTM
6 years, 7 months ago (2014-05-19 13:04:27 UTC) #7
wibling-chromium
lgtm lgtm2
6 years, 7 months ago (2014-05-19 13:36:16 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 14:27:38 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 15:53:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/8876)
6 years, 7 months ago (2014-05-19 15:53:32 UTC) #11
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 7 months ago (2014-05-20 08:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/287383004/1
6 years, 7 months ago (2014-05-20 08:25:34 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 09:38:50 UTC) #14
Message was sent while issue was closed. 
Change committed as 174358

Powered by Google App Engine
This is Rietveld 408576698