Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: content/browser/renderer_host/media/device_request_message_filter.cc

Issue 287383002: Implement getMediaDevices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't clear labels in DRMF. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/device_request_message_filter.cc
diff --git a/content/browser/renderer_host/media/device_request_message_filter.cc b/content/browser/renderer_host/media/device_request_message_filter.cc
index 4aaf2398d5593685ee4bf9501f928bfbe16d5876..ccc9aad04ea8694e5d8f169f4612c88f229e715a 100644
--- a/content/browser/renderer_host/media/device_request_message_filter.cc
+++ b/content/browser/renderer_host/media/device_request_message_filter.cc
@@ -10,15 +10,6 @@
#include "content/common/media/media_stream_messages.h"
#include "content/public/browser/resource_context.h"
-// Clears the MediaStreamDevice.name from all devices in |device_list|.
-static void ClearDeviceLabels(content::StreamDeviceInfoArray* devices) {
- for (content::StreamDeviceInfoArray::iterator device_itr = devices->begin();
- device_itr != devices->end();
- ++device_itr) {
- device_itr->device.name.clear();
- }
-}
-
namespace content {
DeviceRequestMessageFilter::DeviceRequestMessageFilter(
@@ -98,12 +89,6 @@ void DeviceRequestMessageFilter::DevicesEnumerated(
return;
}
- // Query for mic and camera permissions.
- if (!resource_context_->AllowMicAccess(request_it->origin))
- ClearDeviceLabels(audio_devices);
- if (!resource_context_->AllowCameraAccess(request_it->origin))
- ClearDeviceLabels(video_devices);
-
// Both audio and video devices are ready for copying.
StreamDeviceInfoArray all_devices = *audio_devices;
all_devices.insert(
@@ -147,13 +132,13 @@ void DeviceRequestMessageFilter::OnGetSources(int request_id,
// Make request to get audio devices.
const std::string& audio_label = media_stream_manager_->EnumerateDevices(
this, -1, -1, resource_context_->GetMediaDeviceIDSalt(), -1,
- MEDIA_DEVICE_AUDIO_CAPTURE, security_origin);
+ MEDIA_DEVICE_AUDIO_CAPTURE, security_origin, resource_context_);
perkj_chrome 2014/05/27 11:57:23 I think Joi has big problems with the lifetime of
Henrik Grunell 2014/05/27 15:33:54 OK. Changed it to insert permission.
DCHECK(!audio_label.empty());
// Make request for video devices.
const std::string& video_label = media_stream_manager_->EnumerateDevices(
this, -1, -1, resource_context_->GetMediaDeviceIDSalt(), -1,
- MEDIA_DEVICE_VIDEO_CAPTURE, security_origin);
+ MEDIA_DEVICE_VIDEO_CAPTURE, security_origin, resource_context_);
DCHECK(!video_label.empty());
requests_.push_back(DeviceRequest(

Powered by Google App Engine
This is Rietveld 408576698