Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 287373002: Navigation buttons should not enable if user can not navigate (Closed)

Created:
6 years, 7 months ago by ankit
Modified:
6 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, AKVT
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Navigation buttons should not enable if user can not navigate Added code to enable/disable navigation buttons(prev/Next). Prev button will be enable only if user can navigate in back direction and similarly Next button will be enable only if user can navigate in forward direction. BUG=374702 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272288

Patch Set 1 #

Patch Set 2 : Modified code as suggested #

Total comments: 1

Patch Set 3 : Modified code as suggested #

Patch Set 4 : Corrected spacing problem and modified java doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M content/shell/browser/shell_android.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
ankit
PTAL
6 years, 7 months ago (2014-05-19 07:51:22 UTC) #1
Ted C
Instead of hiding the controls, it should just be setting them to disabled like on ...
6 years, 7 months ago (2014-05-19 23:25:28 UTC) #2
ankit
PTAL new patch
6 years, 7 months ago (2014-05-20 05:49:46 UTC) #3
Ted C
https://codereview.chromium.org/287373002/diff/20001/content/shell/android/java/src/org/chromium/content_shell/Shell.java File content/shell/android/java/src/org/chromium/content_shell/Shell.java (right): https://codereview.chromium.org/287373002/diff/20001/content/shell/android/java/src/org/chromium/content_shell/Shell.java#newcode233 content/shell/android/java/src/org/chromium/content_shell/Shell.java:233: mPrevButton.setEnabled(mContentViewCore.canGoBack()); In my previous comment, I meant that we ...
6 years, 7 months ago (2014-05-20 22:29:37 UTC) #4
ankit
Sorry for misunderstanding. I have made changes as suggested. Added a new @CalledByNative in java ...
6 years, 7 months ago (2014-05-21 05:13:14 UTC) #5
Ted C
lgtm thanks!
6 years, 7 months ago (2014-05-21 17:38:52 UTC) #6
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 7 months ago (2014-05-22 03:24:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 03:26:57 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 09:32:27 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 12:39:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9753)
6 years, 7 months ago (2014-05-22 12:39:17 UTC) #11
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 7 months ago (2014-05-22 12:54:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 12:54:47 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 12:57:46 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 12:59:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9753)
6 years, 7 months ago (2014-05-22 12:59:36 UTC) #16
ankit
On 2014/05/22 12:59:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-22 13:32:31 UTC) #17
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 7 months ago (2014-05-22 15:59:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 16:00:16 UTC) #19
Ted C
On 2014/05/22 13:32:31, ankit2.kumar wrote: > On 2014/05/22 12:59:36, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-22 16:00:31 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:04:16 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 16:06:40 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9753)
6 years, 7 months ago (2014-05-22 16:06:40 UTC) #23
ankit
On 2014/05/22 16:06:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-22 16:09:48 UTC) #24
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 7 months ago (2014-05-22 16:18:13 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 16:19:47 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:23:49 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 16:26:09 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9753)
6 years, 7 months ago (2014-05-22 16:26:10 UTC) #29
ankit
The CQ bit was checked by ankit2.kumar@samsung.com
6 years, 7 months ago (2014-05-22 16:27:33 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 16:28:37 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:32:55 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 16:35:19 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9753)
6 years, 7 months ago (2014-05-22 16:35:19 UTC) #34
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 7 months ago (2014-05-22 17:21:36 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001
6 years, 7 months ago (2014-05-22 17:28:32 UTC) #36
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 19:57:12 UTC) #37
Message was sent while issue was closed.
Change committed as 272288

Powered by Google App Engine
This is Rietveld 408576698