Navigation buttons should not enable if user can not navigate

Navigation buttons should not enable if user can not navigate

Added code to enable/disable navigation buttons(prev/Next).
Prev button will be enable only if user can navigate in back direction and 
similarly Next button will be enable only if user can navigate in forward direction.



BUG=374702
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272288

[ankit, 2014-05-19 07:51:22]

PTAL

[Ted C, 2014-05-19 23:25:28]

Instead of hiding the controls, it should just be setting them to disabled like
on other platforms.  We should hook into PlatformEnableUIControl and do the
correct thing on Android as well.

[ankit, 2014-05-20 05:49:46]

PTAL new patch

[Ted C, 2014-05-20 22:29:37]

https://codereview.chromium.org/287373002/diff/20001/content/shell/android/ja...
File content/shell/android/java/src/org/chromium/content_shell/Shell.java
(right):

https://codereview.chromium.org/287373002/diff/20001/content/shell/android/ja...
content/shell/android/java/src/org/chromium/content_shell/Shell.java:233:
mPrevButton.setEnabled(mContentViewCore.canGoBack());
In my previous comment, I meant that we should actually be hooking directly into
PlatformEnableUIControl in shell_android.cc.  Currently that method is empty,
but we should just add a new method in java:

@CalledByNative
private void enableUiControl(int controlId, boolean enabled) {
    if (controlId == 0) mPrevButton.setEnabled(enabled);
    else if (controlId == 1) mNextButton.setEnabled(enabled);
}

Then we just call that from shell_android and that keeps the android port closer
to the other platforms.

[ankit, 2014-05-21 05:13:14]

Sorry for misunderstanding. 
I have made changes as suggested. Added a new @CalledByNative in java side and
calling it from shell_android. It will take care of updating the navigation
buttons accordingly.

PTAL new patch set.

[Ted C, 2014-05-21 17:38:52]

lgtm thanks!

[ankit, 2014-05-22 03:24:18]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-22 03:26:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[commit-bot: I haz the power, 2014-05-22 09:32:27]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-22 12:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:39:17]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[ankit, 2014-05-22 12:54:32]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-22 12:54:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[commit-bot: I haz the power, 2014-05-22 12:57:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 12:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 12:59:36]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[ankit, 2014-05-22 13:32:31]

On 2014/05/22 12:59:36, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_gpu_triggered_tests on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

@Ted C
I am not able to find out build failure reason. Changes done in this CL should
not cause any build failure.
PTAL

[Ted C, 2014-05-22 15:59:41]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:00:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[Ted C, 2014-05-22 16:00:31]

On 2014/05/22 13:32:31, ankit2.kumar wrote:
> On 2014/05/22 12:59:36, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   win_gpu_triggered_tests on tryserver.chromium.gpu
> >
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
> 
> @Ted C
> I am not able to find out build failure reason. Changes done in this CL should
> not cause any build failure.
> PTAL

These look like flakes.  I'll just check the commit box again.  If it keeps
happening on the same
bot for the same tests then it will be suspicious about this change, but thus
far it seems
random.

[commit-bot: I haz the power, 2014-05-22 16:04:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 16:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:06:40]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[ankit, 2014-05-22 16:09:48]

On 2014/05/22 16:06:40, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_gpu_triggered_tests on tryserver.chromium.gpu
>
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

@Ted C
Please suggest what to do further.

[ankit, 2014-05-22 16:18:13]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-22 16:19:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[commit-bot: I haz the power, 2014-05-22 16:23:49]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 16:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:26:10]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[ankit, 2014-05-22 16:27:33]

The CQ bit was checked by ankit2.kumar@samsung.com

[commit-bot: I haz the power, 2014-05-22 16:28:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[commit-bot: I haz the power, 2014-05-22 16:32:55]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 16:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 16:35:19]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Ted C, 2014-05-22 17:21:36]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2014-05-22 17:28:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ankit2.kumar@samsung.com/287373002/60001

[commit-bot: I haz the power, 2014-05-22 19:57:12]

Change committed as 272288