Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2873693002: [infra] Ensure args.gn is updated for the Linux cross builds during gclient runhooks. (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[infra] Ensure args.gn is updated for the Linux cross builds during gclient runhooks. Issue #29580 R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d00f99cde9af68d374657c1a610616e15b2e17d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/generate_buildfiles.py View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 7 months ago (2017-05-09 16:35:14 UTC) #2
zra
lgtm
3 years, 7 months ago (2017-05-09 16:43:55 UTC) #3
rmacnak
3 years, 7 months ago (2017-05-09 16:47:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d00f99cde9af68d374657c1a610616e15b2e17d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698