Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/accessibility/browser_accessibility_com_win.cc

Issue 2873683003: Use BrowserAccessibilityComWin::Destroy to clear delegate and owner. (Closed)
Patch Set: Clang Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_com_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_com_win.cc b/content/browser/accessibility/browser_accessibility_com_win.cc
index 09ee21849deb157a18f4dc48e2021eacf5493449..2a33d8328b910d6b3b60cd3a2a4bd7dbac53f204 100644
--- a/content/browser/accessibility/browser_accessibility_com_win.cc
+++ b/content/browser/accessibility/browser_accessibility_com_win.cc
@@ -4094,6 +4094,17 @@ BrowserAccessibilityManager* BrowserAccessibilityComWin::Manager() const {
return manager;
}
+//
+// AXPlatformNode overrides
+//
+void BrowserAccessibilityComWin::Destroy() {
+ // Detach BrowserAccessibilityWin from us.
+ owner_ = nullptr;
+ delegate_ = nullptr;
+
+ AXPlatformNode::Destroy();
dmazzoni 2017/05/10 15:17:52 You definitely want AXPlatformNodeWin::Destroy() h
+}
+
std::vector<base::string16> BrowserAccessibilityComWin::ComputeTextAttributes()
const {
std::vector<base::string16> attributes;

Powered by Google App Engine
This is Rietveld 408576698