Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 2873683003: Use BrowserAccessibilityComWin::Destroy to clear delegate and owner. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index 0fe7041a46e7e8c6f55d62f46a395233b2ec9fa1..6dcaa83a5500e2914a6513d23d21050d90c2303f 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -36,9 +36,10 @@ void BrowserAccessibilityWin::UpdatePlatformAttributes() {
void BrowserAccessibilityWin::Destroy() {
if (browser_accessibility_com_) {
- browser_accessibility_com_->SetOwner(nullptr);
- // TODO(dougt) AXPlatformNode::Reset
- browser_accessibility_com_->Init(nullptr);
+ // Clear the delegate and owner from our
+ // BrowserAccessibilityComWin object.
+ browser_accessibility_com_->detach();
+
browser_accessibility_com_->Release();
browser_accessibility_com_ = nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698