PaymentHandler: Implement GetAllPaymentApps().

content/browser/payments/payment_app_provider_impl.cc

Index: content/browser/payments/payment_app_provider_impl.cc
diff --git a/content/browser/payments/payment_app_provider_impl.cc b/content/browser/payments/payment_app_provider_impl.cc
index af8492a371b9bb4ddd42cd801e1d74c2552d477c..293f10d8ebda48a0d3722df4a541726b0b745ab1 100644
--- a/content/browser/payments/payment_app_provider_impl.cc
+++ b/content/browser/payments/payment_app_provider_impl.cc
@@ -73,6 +73,23 @@ void GetAllManifestsOnIO(
       base::Bind(&DidGetAllManifestsOnIO, callback));
 }
 
+void DidGetAllPaymentAppsOnIO(
+    PaymentAppProvider::GetAllPaymentAppsCallback callback,
+    PaymentAppProvider::PaymentApps apps) {
+  BrowserThread::PostTask(
+      BrowserThread::UI, FROM_HERE,
+      base::BindOnce(std::move(callback), base::Passed(std::move(apps))));
+}
+
+void GetAllPaymentAppsOnIO(
+    scoped_refptr<PaymentAppContextImpl> payment_app_context,
+    PaymentAppProvider::GetAllPaymentAppsCallback callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  payment_app_context->payment_app_database()->ReadAllPaymentApps(
+      base::BindOnce(&DidGetAllPaymentAppsOnIO, std::move(callback)));
+}
+
 void DispatchPaymentRequestEventError(
     ServiceWorkerStatusCode service_worker_status) {
   NOTIMPLEMENTED();
@@ -163,6 +180,22 @@ void PaymentAppProviderImpl::GetAllManifests(
       base::Bind(&GetAllManifestsOnIO, payment_app_context, callback));
 }
 
+void PaymentAppProviderImpl::GetAllPaymentApps(
+    BrowserContext* browser_context,
+    GetAllPaymentAppsCallback callback) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+  StoragePartitionImpl* partition = static_cast<StoragePartitionImpl*>(
+      BrowserContext::GetDefaultStoragePartition(browser_context));

[nasko, 2017/05/09 22:46:44]

Are payments supported in Chrome Apps? If yes, then this is going to break in
those cases.

[zino, 2017/05/10 15:57:42]

This feature shouldn't be supported in Chrome Apps.
This Payment Handler is providing third-party payment processing to merchant
site.
When the Payment Request API is initiated in merchant site, the browser will
display the proper payment instruments and then invoke the payment instrument by
user interaction.
At that time, if the third-party payment app is Chrome App, then the payment app
can get a excessive permission.
So, it can't be Chrome App for security reason.
(In the past CL's comment: https://codereview.chromium.org/2586213002/#msg33)

[nasko, 2017/05/11 21:45:39]

If this is the case, do we block the API in the case of Chrome Apps? Do we have
a test to ensure we won't regress that?

[zino, 2017/05/12 20:59:21]

Oh, I thought that the service worker is only allowed in SecureContext but it's
not true.
Okay I'll follow-up this issue. I think we should block accessing the
PaymentManager in Extension side.
(FYI, the PaymentManager is an extension of SW registration like PushManager.
and it is used to store payment instruments.)

If you don't mind, can I fix this in separated CL?
The change should be in Blink and extension side(api test) as well as has a bit
different content with this patch's title.
I already filed a bug here:
https://bugs.chromium.org/p/chromium/issues/detail?id=721897

Anyway, this feature is still behind runtime flag. So, the PaymentManager is not
exposed.
Also, even if someone enables the feature and then store some instruments, this
patch ignores reading the data (using GetDefaultStoragePartition only).

[nasko, 2017/05/12 21:12:10]

chrome-extension: is likely treated as a secure context.
Yes, separate CL is totally fine, and actually encouraged : ).
Thanks!

+  scoped_refptr<PaymentAppContextImpl> payment_app_context =
+      partition->GetPaymentAppContext();
+
+  BrowserThread::PostTask(
+      BrowserThread::IO, FROM_HERE,
+      base::BindOnce(&GetAllPaymentAppsOnIO, payment_app_context,
+                     std::move(callback)));
+}
+
 void PaymentAppProviderImpl::InvokePaymentApp(
     BrowserContext* browser_context,
     int64_t registration_id,