PaymentHandler: Implement GetAllPaymentApps().

content/public/browser/payment_instrument.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_PAYMENT_INSTRUMENT_H_
+#define CONTENT_PUBLIC_BROWSER_PAYMENT_INSTRUMENT_H_
+
+#include <stdint.h>
+#include <string>
+#include <vector>
+
+#include "content/common/content_export.h"
+#include "url/gurl.h"
+
+namespace content {
+
+// This class represents the stored payment instrument in UA.
+struct CONTENT_EXPORT PaymentInstrument {

[nasko, 2017/05/11 21:45:39]

Since this struct is contained entirely inside content/, there is no reason to
expose it in the public API. Please move it to content/browser/payments/
subdirectory, since it is specific to that code.

[zino, 2017/05/12 20:59:21]

The struct is used in chrome layer.
Once the payment request API is called from mechant site, browser should display
all payment instruments.
At that time, we can use this implementation(GetAllPaymentApps()). The
instrument data is passed to chrome side to display instruments on UI.

Looking into the following link (line number 46), you can see the use case.
https://codereview.chromium.org/2867273003/diff/60001/chrome/browser/android/...

[nasko, 2017/05/12 21:12:10]

I don't see an include statement for that file there. It should be explicitly
included, not pulled in through another dependency.

The content/public/ API policy is that we don't expose it without its usage.
Please update the CL description to clarify that the follow up CL contains the
usage of the public API.

+  PaymentInstrument();
+  ~PaymentInstrument();
+
+  // Id of the service worker registration this instrument is associated with.
+  int64_t registration_id = 0;
+
+  // Id of this payment instrument. This key will be passed to the payment
+  // handler to indicate the instrument selected by the user.
+  std::string instrument_key;
+
+  // Origin of the payment app provider that provides this payment instrument.
+  GURL origin;
+
+  // Label for this payment instrument.
+  std::string name;
+
+  // A list of one or more payment method identifiers of the payment methods
+  // supported by this payment instrument.
+  std::vector<std::string> enabled_methods;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_PAYMENT_INSTRUMENT_H_