Add unit tests for NTLMv1 portable implementation

net/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
@@ skipping 775 matching lines @@
       "filter/source_stream.h",
       "filter/source_stream_type_list.h",
       "http/bidirectional_stream.cc",
       "http/bidirectional_stream.h",
       "http/bidirectional_stream_impl.cc",
       "http/bidirectional_stream_impl.h",
       "http/bidirectional_stream_request_info.cc",
       "http/bidirectional_stream_request_info.h",
       "http/broken_alternative_services.cc",
       "http/broken_alternative_services.h",
-      "http/des.cc",
-      "http/des.h",
       "http/failing_http_transaction_factory.cc",
       "http/failing_http_transaction_factory.h",
       "http/http_auth.cc",
       "http/http_auth.h",
       "http/http_auth_cache.cc",
       "http/http_auth_cache.h",
       "http/http_auth_controller.cc",
       "http/http_auth_controller.h",
       "http/http_auth_filter.cc",
       "http/http_auth_filter.h",
@@ skipping 68 matching lines @@
       "http/http_stream_factory_impl_job.h",
       "http/http_stream_factory_impl_job_controller.cc",
       "http/http_stream_factory_impl_job_controller.h",
       "http/http_stream_factory_impl_request.cc",
       "http/http_stream_factory_impl_request.h",
       "http/http_stream_parser.cc",
       "http/http_stream_parser.h",
       "http/http_transaction.h",
       "http/http_transaction_factory.h",
       "http/http_version.h",
-      "http/md4.cc",
-      "http/md4.h",
       "http/partial_data.cc",
       "http/partial_data.h",
       "http/proxy_client_socket.cc",
       "http/proxy_client_socket.h",
       "http/proxy_connect_redirect_http_stream.cc",
       "http/proxy_connect_redirect_http_stream.h",
       "http/transport_security_persister.cc",
       "http/transport_security_persister.h",
       "http/transport_security_state_static.h",
       "http/url_security_manager.cc",
@@ skipping 860 matching lines @@
     if (is_posix) {
       if (posix_avoid_mmap) {
         sources -= [ "disk_cache/blockfile/mapped_file_posix.cc" ]
       } else {
         sources -= [ "disk_cache/blockfile/mapped_file_avoid_mmap_posix.cc" ]
       }
     }
 
     if (!is_win) {
       sources += [
+        "ntlm/des.cc",
+        "ntlm/des.h",
+        "ntlm/md4.cc",
+        "ntlm/md4.h",
+        "ntlm/ntlm.cc",
+        "ntlm/ntlm.h",
         "ntlm/ntlm_buffer_reader.cc",
         "ntlm/ntlm_buffer_reader.h",
         "ntlm/ntlm_buffer_writer.cc",
         "ntlm/ntlm_buffer_writer.h",
         "ntlm/ntlm_constants.h",

[Ryan Sleevi, 2017/07/12 17:56:38]

Apologies that I missed this with the first CL, but my understanding from
brettw@ is the preference is to list all sources (in the sources) and then
subjectively subtract them, rather than add them.

The reporting doesn't seem to follow this pattern, but if you look at the
various build config below, the majority follow this.

(The += tends to be for stuff that is otherwise filtered out by the GNI configs)

[zentaro, 2017/07/13 17:10:19]

Done.

       ]
     }
 
     if (!enable_built_in_dns) {
       sources -= [
         "dns/address_sorter_posix.cc",
         "dns/address_sorter_posix.h",
         "dns/dns_client.cc",
       ]
     }
@@ skipping 2883 matching lines @@
     "ftp/ftp_ctrl_response_buffer_unittest.cc",
     "ftp/ftp_directory_listing_parser_ls_unittest.cc",
     "ftp/ftp_directory_listing_parser_unittest.cc",
     "ftp/ftp_directory_listing_parser_unittest.h",
     "ftp/ftp_directory_listing_parser_vms_unittest.cc",
     "ftp/ftp_directory_listing_parser_windows_unittest.cc",
     "ftp/ftp_network_transaction_unittest.cc",
     "ftp/ftp_util_unittest.cc",
     "http/bidirectional_stream_unittest.cc",
     "http/broken_alternative_services_unittest.cc",
-    "http/des_unittest.cc",
     "http/http_auth_cache_unittest.cc",
     "http/http_auth_challenge_tokenizer_unittest.cc",
     "http/http_auth_controller_unittest.cc",
     "http/http_auth_filter_unittest.cc",
     "http/http_auth_gssapi_posix_unittest.cc",
     "http/http_auth_handler_basic_unittest.cc",
     "http/http_auth_handler_digest_unittest.cc",
     "http/http_auth_handler_factory_unittest.cc",
     "http/http_auth_handler_mock.cc",
     "http/http_auth_handler_mock.h",
@@ skipping 533 matching lines @@
   if (is_chromeos) {
     sources -= [ "proxy/proxy_config_service_linux_unittest.cc" ]
   }
 
   if (!is_proto_quic && v8_use_external_startup_data) {
     deps += [ "//gin" ]
   }
 
   if (!is_win) {
     sources += [
+      "http/http_auth_handler_ntlm_portable_unittest.cc",
+      "ntlm/des_unittest.cc",
       "ntlm/ntlm_buffer_reader_unittest.cc",
       "ntlm/ntlm_buffer_writer_unittest.cc",
+      "ntlm/ntlm_test_data.h",
+      "ntlm/ntlm_unittest.cc",
     ]
   }
 
   if (!use_nss_certs) {
     sources -= [
       "cert/internal/trust_store_nss_unittest.cc",
       "cert/nss_cert_database_unittest.cc",
       "ssl/client_cert_store_nss_unittest.cc",
       "ssl/ssl_platform_key_nss_unittest.cc",
     ]
@@ skipping 832 matching lines @@
   ]
   deps = [
     ":net_fuzzer_test_support",
     ":test_support",
     "//base",
     "//net",
   ]
   dict = "data/fuzzer_dictionaries/net_spdy_session_fuzzer.dict"
   seed_corpus = "data/fuzzer_data/net_spdy_session_fuzzer/"
 }