Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2873633002: Pass data objects to ConstantEmitter (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -56 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 11 chunks +38 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 3 chunks +15 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 3 chunks +11 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-09 13:06:22 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-09 18:09:48 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-10 07:28:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
958ab524c42c537d80871dec97935b3d325c3567 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698