ServiceWorker: support Response.{status,statusText,headers} [blink] (2/3)

Source/platform/exported/WebServiceWorkerResponse.cpp

Index: Source/platform/exported/WebServiceWorkerResponse.cpp
diff --git a/Source/platform/exported/WebServiceWorkerResponse.cpp b/Source/platform/exported/WebServiceWorkerResponse.cpp
index 6b1128cee18c89ee922f1d3a7cee48efe3dbdc66..5ef5fe0839de9a280d7749ee9d2d3ce52ce27f5b 100644
--- a/Source/platform/exported/WebServiceWorkerResponse.cpp
+++ b/Source/platform/exported/WebServiceWorkerResponse.cpp
@@ -7,34 +7,73 @@
 
 namespace blink {
 
-void WebServiceWorkerResponse::setStatusCode(unsigned short statusCode)
+class WebServiceWorkerResponsePrivate : public RefCounted<WebServiceWorkerResponsePrivate> {

[falken, 2014/05/26 09:06:59]

I have a naive question: what's the motivation for using this class instead of
just having the private fields directly in WebServiceWorkerResponse? Do we
expect multiple WebServiceWorkerResponse to refer to the same Private? (I see
it's a common pattern in public...)

[kinuko, 2014/05/26 13:51:35]

We want to store map-like data in WebServiceWorkerResponse but we don't have
public exportable type at public blink interface for that (like WebVector for
Vector), so I moved them into private impl class. (The refcnt'ed shared part is
not really necessary in our case, I just chose it for easier copy handling)

[falken, 2014/05/26 14:59:31]

Ah I see!

+public:
+    unsigned short status;
+    WebString statusText;
+    HashMap<String, String> headers;
+};
+
+WebServiceWorkerResponse::WebServiceWorkerResponse()
+    : m_private(adoptRef(new WebServiceWorkerResponsePrivate))
+{
+}
+
+void WebServiceWorkerResponse::reset()
+{
+    m_private.reset();
+}
+
+void WebServiceWorkerResponse::assign(const WebServiceWorkerResponse& other)
+{
+    m_private = other.m_private;
+}
+
+void WebServiceWorkerResponse::setStatus(unsigned short status)
 {
-    m_statusCode = statusCode;
+    m_private->status = status;
 }
 
-unsigned short WebServiceWorkerResponse::statusCode() const
+unsigned short WebServiceWorkerResponse::status() const
 {
-    return m_statusCode;
+    return m_private->status;
 }
 
 void WebServiceWorkerResponse::setStatusText(const WebString& statusText)
 {
-    m_statusText = statusText;
+    m_private->statusText = statusText;
 }
 
 WebString WebServiceWorkerResponse::statusText() const
 {
-    return m_statusText;
+    return m_private->statusText;
+}
+
+void WebServiceWorkerResponse::setHeader(const WebString& key, const WebString& value)
+{
+    m_private->headers.set(key, value);
+}
+
+WebVector<WebString> WebServiceWorkerResponse::getHeaderKeys() const
+{
+    Vector<String> keys;
+    copyKeysToVector(m_private->headers, keys);
+    return keys;
+}
+
+WebString WebServiceWorkerResponse::getHeader(const WebString& key) const
+{
+    return m_private->headers.get(key);
 }
 
-void WebServiceWorkerResponse::setMethod(const WebString& method)
+void WebServiceWorkerResponse::setHeaders(const HashMap<String, String>& headers)
 {
-    m_method = method;
+    m_private->headers = headers;
 }
 
-WebString WebServiceWorkerResponse::method() const
+const HashMap<String, String>& WebServiceWorkerResponse::headers() const
 {
-    return m_method;
+    return m_private->headers;
 }
 
 } // namespace blink