Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: Source/modules/serviceworkers/Response.idl

Issue 287363004: ServiceWorker: support Response.{status,statusText,headers} [blink] (2/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/Response.idl
diff --git a/Source/modules/serviceworkers/Response.idl b/Source/modules/serviceworkers/Response.idl
index 140786a6f774b5116706797a8b8e4a4fcf30ce8f..03b8e57bd82cb9f69336a8504f10fd067cffc960 100644
--- a/Source/modules/serviceworkers/Response.idl
+++ b/Source/modules/serviceworkers/Response.idl
@@ -7,16 +7,15 @@
RuntimeEnabled=ServiceWorker,
Exposed=ServiceWorker
] interface Response {
- attribute unsigned short statusCode;
+ attribute unsigned short status;
- // FIXME: Spec uses ByteString for these. We must perform the DOMString -> ByteString conversion manually (crbug.com/347426).
+ // FIXME: Spec uses ByteString for this. We must perform the DOMString -> ByteString conversion manually (crbug.com/347426).
attribute DOMString statusText;
- attribute DOMString method;
- // FIXME: Implement HeaderMap which uses the MapClass WebIDL attribute (crbug.com/347435).
- // FIXME: Can't return Dictionaries yet (crbug.com/364025).
- // getter Dictionary headers();
- setter void headers(Dictionary items);
+ // Implements https://github.com/slightlyoff/ServiceWorker/issues/268
+ attribute HeaderMap headers;
+ getter DOMString getHeader(DOMString value);
jsbell 2014/05/23 20:59:49 Looks like the getter/setter are gone in the lates
kinuko 2014/05/26 05:45:13 Yes, so I updated the code.
+ setter void setHeader(DOMString name, DOMString value);
// FIXME: Implement the following:
// attribute DOMString url;

Powered by Google App Engine
This is Rietveld 408576698