Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: Source/modules/serviceworkers/Response.cpp

Issue 287363004: ServiceWorker: support Response.{status,statusText,headers} [blink] (2/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/Response.h ('k') | Source/modules/serviceworkers/Response.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/Response.cpp
diff --git a/Source/modules/serviceworkers/Response.cpp b/Source/modules/serviceworkers/Response.cpp
index 00f006d0338496ef478b65a65c93c5698a65552a..9b4c9c1111f453ba1207b4b4e99458c70d57dcb5 100644
--- a/Source/modules/serviceworkers/Response.cpp
+++ b/Source/modules/serviceworkers/Response.cpp
@@ -22,31 +22,28 @@ PassRefPtr<Response> Response::create(const Dictionary& responseInit)
return adoptRef(new Response(ResponseInit(responseInit)));
}
-void Response::headers(const Dictionary& headers)
-{
- notImplemented();
-}
-
-Dictionary* Response::headers()
+PassRefPtr<HeaderMap> Response::headers() const
{
// FIXME: Implement. Spec will eventually whitelist allowable headers.
- return &m_headers;
+ return m_headers;
}
void Response::populateWebServiceWorkerResponse(blink::WebServiceWorkerResponse& response)
{
- response.setStatusCode(statusCode());
+ response.setStatus(status());
response.setStatusText(statusText());
- response.setMethod(method());
+ response.setHeaders(m_headers->headerMap());
}
Response::Response(const ResponseInit& responseInit)
- : m_statusCode(responseInit.statusCode)
+ : m_status(responseInit.status)
, m_statusText(responseInit.statusText)
- , m_method(responseInit.method)
, m_headers(responseInit.headers)
{
ScriptWrappable::init(this);
+
+ if (!m_headers)
+ m_headers = HeaderMap::create();
}
} // namespace WebCore
« no previous file with comments | « Source/modules/serviceworkers/Response.h ('k') | Source/modules/serviceworkers/Response.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698