ServiceWorker: support Response.{status,statusText,headers} [blink] (2/3)

Source/modules/serviceworkers/Response.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Response_h
 #define Response_h
 
 #include "bindings/v8/Dictionary.h"
 #include "bindings/v8/ScriptWrappable.h"
+#include "modules/serviceworkers/HeaderMap.h"
 #include "wtf/RefCounted.h"
+#include "wtf/RefPtr.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink { class WebServiceWorkerResponse; }
 
 namespace WebCore {
 
 struct ResponseInit;
 
 class Response FINAL : public ScriptWrappable, public RefCounted<Response> {
 public:
     static PassRefPtr<Response> create();
     static PassRefPtr<Response> create(const Dictionary& responseInit);
     ~Response() { };
 
-    unsigned short statusCode() { return m_statusCode; }
-    void setStatusCode(unsigned short statusCode) { m_statusCode = statusCode; }
+    unsigned short status() { return m_status; }
+    void setStatus(unsigned short status) { m_status = status; }
 
     String statusText() { return m_statusText; }
     void setStatusText(const String& statusText) { m_statusText = statusText; }
 
-    String method() { return m_method; }
-    void setMethod(const String& method) { m_method = method; }
-
-    Dictionary* headers();
-    void headers(const Dictionary&);
+    PassRefPtr<HeaderMap> headers();
+    void setHeaders(PassRefPtr<HeaderMap>);

[jsbell, 2014/05/23 20:59:49]

Where is this used?

[kinuko, 2014/05/26 05:45:13]

The spec's updated and now it's (officially) a readonly attribute, so I removed
it.

+    String getHeader(const String& name);
+    bool namedPropertyQuery(const String& name, ExceptionState&);
+    void namedPropertyEnumerator(Vector<String>& names, ExceptionState&);

[falken, 2014/05/24 14:32:36]

The Blink IDL documentation seems to say you must say 
[Custom=PropertyQuery|PropertyEnumerator] in the IDL to use these.[1] Is this
wrong or am I reading it wrong?

[1]
http://www.chromium.org/blink/webidl/blink-idl-extended-attributes#TOC-Custom...

[kinuko, 2014/05/26 05:45:13]

I was likely mistaken, and the spec's updated so we no longer need to worry
about these ones. Removed.

+    bool setHeader(const String& name, const String& value);
 
     void populateWebServiceWorkerResponse(blink::WebServiceWorkerResponse&);
 
 private:
     explicit Response(const ResponseInit&);
-    unsigned short m_statusCode;
+    unsigned short m_status;
     String m_statusText;
-    String m_method;
-    Dictionary m_headers;
+    RefPtr<HeaderMap> m_headers;
 };
 
 } // namespace WebCore
 
 #endif // Response_h