Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 287363002: Partial revert of "Next bunch of fixes for check elimination". (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Partial revert of "Next bunch of fixes for check elimination". This reverts the part of r21154 that introduced the CHECK()s to verify state of objects with stable maps during code generation. The CHECK()s seem to trigger a non-critical hidden bug in the map stability mechanism. We will re-add these CHECK()s once the bug is found and fixed. BUG=372173 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-19 05:48:49 UTC) #1
Sven Panne
LGTM (rubber-stamped)
6 years, 7 months ago (2014-05-19 06:24:12 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-19 07:08:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698