Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: components/update_client/test_configurator.h

Issue 2873533002: Prepare to abstract PersistedData by making it part of the configurator.
Patch Set: Rename pref_ to pref_service_. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/configurator.h ('k') | components/update_client/test_configurator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/test_configurator.h
diff --git a/components/update_client/test_configurator.h b/components/update_client/test_configurator.h
index 1f26ec051d223e159c6e7d3a4f311b5c342357d7..99609d4d96497872188afd735c8b90aa976ad2cd 100644
--- a/components/update_client/test_configurator.h
+++ b/components/update_client/test_configurator.h
@@ -82,8 +82,8 @@ class TestConfigurator : public Configurator {
bool EnabledCupSigning() const override;
scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
const override;
- PrefService* GetPrefService() const override;
bool IsPerUserInstall() const override;
+ std::unique_ptr<PersistedData> CreateMetadata() const override;
void SetBrand(const std::string& brand);
void SetOnDemandTime(int seconds);
@@ -93,6 +93,7 @@ class TestConfigurator : public Configurator {
void SetEnabledComponentUpdates(bool enabled_component_updates);
void SetUpdateCheckUrl(const GURL& url);
void SetPingUrl(const GURL& url);
+ void SetPrefService(PrefService* pref);
private:
friend class base::RefCountedThreadSafe<TestConfigurator>;
@@ -109,6 +110,7 @@ class TestConfigurator : public Configurator {
bool enabled_component_updates_;
GURL update_check_url_;
GURL ping_url_;
+ PrefService* pref_service_;
scoped_refptr<net::TestURLRequestContextGetter> context_;
« no previous file with comments | « components/update_client/configurator.h ('k') | components/update_client/test_configurator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698