Prepare to abstract PersistedData by making it part of the configurator.

components/update_client/test_configurator.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_TEST_CONFIGURATOR_H_
 #define COMPONENTS_UPDATE_CLIENT_TEST_CONFIGURATOR_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 64 matching lines @@
   std::string ExtraRequestParams() const override;
   std::string GetDownloadPreference() const override;
   net::URLRequestContextGetter* RequestContext() const override;
   scoped_refptr<OutOfProcessPatcher> CreateOutOfProcessPatcher() const override;
   bool EnabledDeltas() const override;
   bool EnabledComponentUpdates() const override;
   bool EnabledBackgroundDownloader() const override;
   bool EnabledCupSigning() const override;
   scoped_refptr<base::SequencedTaskRunner> GetSequencedTaskRunner()
       const override;
-  PrefService* GetPrefService() const override;
   bool IsPerUserInstall() const override;
+  std::unique_ptr<PersistedData> CreateMetadata() const override;
 
   void SetBrand(const std::string& brand);
   void SetOnDemandTime(int seconds);
   void SetInitialDelay(int seconds);
   void SetDownloadPreference(const std::string& download_preference);
   void SetEnabledCupSigning(bool use_cup_signing);
   void SetEnabledComponentUpdates(bool enabled_component_updates);
   void SetUpdateCheckUrl(const GURL& url);
   void SetPingUrl(const GURL& url);
+  void SetPrefService(PrefService* pref);
 
  private:
   friend class base::RefCountedThreadSafe<TestConfigurator>;
 
   ~TestConfigurator() override;
 
   scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
 
   std::string brand_;
   int initial_time_;
   int ondemand_time_;
   std::string download_preference_;
   bool enabled_cup_signing_;
   bool enabled_component_updates_;
   GURL update_check_url_;
   GURL ping_url_;
+  PrefService* pref_;

[Devlin, 2017/06/05 16:13:38]

nit: maybe s/pref_/pref_service_?  A pref is something returned by the pref
service.

[Minh X. Nguyen, 2017/06/05 18:16:38]

Done.

 
   scoped_refptr<net::TestURLRequestContextGetter> context_;
 
   DISALLOW_COPY_AND_ASSIGN(TestConfigurator);
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_TEST_CONFIGURATOR_H_