Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2873503007: Add support for converting elements to plugin API objects (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for converting elements to plugin API objects R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a70e29ac604498094a11e63369b6f8800486dba3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+712 lines, -6 lines) Patch
M pkg/analyzer_plugin/lib/utilities/analyzer_converter.dart View 3 chunks +278 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/test/support/abstract_context.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/test/utilities/analyzer_converter_test.dart View 4 chunks +428 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-09 19:41:34 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-09 19:48:38 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-09 20:02:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a70e29ac604498094a11e63369b6f8800486dba3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698