third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp - Issue 2873503002: NOT YET READY: Improve granularity of window namespaces in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

Issue 2873503002: NOT YET READY: Improve granularity of window namespaces in Blink.

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

index fff97d9d34d8f5ef45666685d46762704c915721..560d866adea3971979613edc3df1ffc768d161f8 100644

--- a/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp

@@ -205,7 +205,8 @@ WebViewBase* WebViewHelper::InitializeWithOpener(

if (!web_widget_client)

web_widget_client = web_view_client->WidgetClient();

web_view_ = static_cast<WebViewBase*>(

- WebView::Create(web_view_client, kWebPageVisibilityStateVisible));

+ WebView::Create(web_view_client, kWebPageVisibilityStateVisible,

+ opener ? opener->View() : nullptr));

web_view_->GetSettings()->SetJavaScriptEnabled(enable_javascript);

web_view_->GetSettings()->SetPluginsEnabled(true);

// Enable (mocked) network loads of image URLs, as this simplifies