third_party/WebKit/Source/web/WebFactoryImpl.h - Issue 2873503002: NOT YET READY: Improve granularity of window namespaces in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFactoryImpl.h

Issue 2873503002: NOT YET READY: Improve granularity of window namespaces in Blink.

Patch Set: Rebasing... Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFactoryImpl.h

diff --git a/third_party/WebKit/Source/web/WebFactoryImpl.h b/third_party/WebKit/Source/web/WebFactoryImpl.h

index 732a9500ceb2b9d9fe3227021b92e2bc1a0555bc..bfcff12a3a14fcd84351e4b39f9b8b8144e30942 100644

--- a/third_party/WebKit/Source/web/WebFactoryImpl.h

+++ b/third_party/WebKit/Source/web/WebFactoryImpl.h

@@ -19,7 +19,8 @@ class WebFactoryImpl : public WebFactory {

ChromeClient* CreateChromeClient(WebViewBase*) const override;

WebViewBase* CreateWebViewBase(WebViewClient*,

- WebPageVisibilityState) const override;

+ WebPageVisibilityState,

+ WebViewBase* opener) const override;

WebLocalFrameBase* CreateWebLocalFrameBase(

WebTreeScopeType,

WebFrameClient*,