third_party/WebKit/Source/core/html/media/MediaControls.h - Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/media/MediaControls.h

Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen (Closed)

Patch Set: Use test-25fps.mp4 instead of counting.mp4 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/media/MediaControls.h

diff --git a/third_party/WebKit/Source/core/html/media/MediaControls.h b/third_party/WebKit/Source/core/html/media/MediaControls.h

index e86fd0ae2c238d14648cf805a91b62885af8f676..b2b00dbbd71ea136c4262275bc9f1b4023c37d0b 100644

--- a/third_party/WebKit/Source/core/html/media/MediaControls.h

+++ b/third_party/WebKit/Source/core/html/media/MediaControls.h

@@ -35,8 +35,11 @@ class CORE_EXPORT MediaControls : public GarbageCollectedMixin {

HTMLMediaElement& MediaElement() const;

- virtual void Show() = 0;

+ // Enables showing of the controls - only shows if appropriate.

+ virtual void MaybeShow() = 0;

+ // Disables showing of the controls - immediately hides.

virtual void Hide() = 0;

virtual void Reset() = 0;

// Notify the media controls that the controlsList attribute has changed.