third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2873493004: [Media Controls] Prevent flicker when enter/exit fullscreen (Closed)

Patch Set: Add virtual/new-remote-playback-pipeline variants to SlowTests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index ae052f1145fda99129cf8ee7b929dbc64a9aae32..06b542b35315441d29edc68e7cd91fa9824c0c6f 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -3687,7 +3687,7 @@ void HTMLMediaElement::UpdateControlsVisibility() {

GetMediaControls()->Reset();

if (ShouldShowControls(RecordMetricsBehavior::kDoRecord))

- GetMediaControls()->Show();

+ GetMediaControls()->MaybeShow();

else

GetMediaControls()->Hide();

}