third_party/WebKit/Source/core/animation/ScrollTimeline.idl - Issue 2873493002: Basic ScrollTimeline implementation for Animation Worklet

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/animation/ScrollTimeline.idl

Issue 2873493002: Basic ScrollTimeline implementation for Animation Worklet (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://wicg.github.io/scroll-animations/#scrolltimeline-interface

	6

	7 [

	8 Constructor(optional ScrollTimelineOptions options),

	9 ConstructorCallWith=Document,

	10 RaisesException=Constructor,

	11 RuntimeEnabled=CompositorWorker,
	alancutter (OOO until 2018) 2017/06/08 05:00:32 I think you want "Exposed(Window CompositorWorker) I think you want "Exposed(Window CompositorWorker)" so that the interface isn't exposed to stable. We should not be seeing a change to LayoutTests/webexposed/global-interface-listing-expected.txt. smcgruer 2017/06/08 14:43:47 Done. Show quoted text On 2017/06/08 05:00:32, alancutter wrote: > I think you want "Exposed(Window CompositorWorker)" so that the interface isn't > exposed to stable. > We should not be seeing a change to > LayoutTests/webexposed/global-interface-listing-expected.txt. Done.
	12 ] interface ScrollTimeline : AnimationTimeline {

	13 readonly attribute Element? scrollSource;

	14 readonly attribute ScrollDirection orientation;

	15 readonly attribute (double or ScrollTimelineAutoKeyword) timeRange;

	16 };

OLD	NEW