Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerListImpl.h

Issue 2873483002: [DMC #5.6] Add type cast for SpellCheckMarkerListImpl (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SpellCheckMarkerListImpl_h 5 #ifndef SpellCheckMarkerListImpl_h
6 #define SpellCheckMarkerListImpl_h 6 #define SpellCheckMarkerListImpl_h
7 7
8 #include "core/editing/markers/DocumentMarkerList.h" 8 #include "core/editing/markers/DocumentMarkerList.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 // Implementation of DocumentMarkerList for Spelling/Grammar markers. 12 // Nearly-complete implementation of DocumentMarkerList for Spelling or Grammar
13 // Markers with touching endpoints are merged on insert. Markers are kept sorted 13 // markers (subclassed by SpellingMarkerListImpl and GrammarMarkerListImpl to
14 // by start offset in order to be able to do this efficiently. 14 // implement the MarkerType() method). Markers with touching endpoints are
15 // merged on insert. Markers are kept sorted by start offset in order to be able
16 // to do this efficiently.
15 class CORE_EXPORT SpellCheckMarkerListImpl : public DocumentMarkerList { 17 class CORE_EXPORT SpellCheckMarkerListImpl : public DocumentMarkerList {
16 public: 18 public:
17 SpellCheckMarkerListImpl() = default;
18
19 // DocumentMarkerList implementations 19 // DocumentMarkerList implementations
20 bool IsEmpty() const final; 20 bool IsEmpty() const final;
21 21
22 void Add(DocumentMarker*) final; 22 void Add(DocumentMarker*) final;
23 void Clear() final; 23 void Clear() final;
24 24
25 const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() const final; 25 const HeapVector<Member<RenderedDocumentMarker>>& GetMarkers() const final;
26 26
27 bool MoveMarkers(int length, DocumentMarkerList* dst_list) final; 27 bool MoveMarkers(int length, DocumentMarkerList* dst_list) final;
28 bool RemoveMarkers(unsigned start_offset, int length) final; 28 bool RemoveMarkers(unsigned start_offset, int length) final;
29 bool RemoveMarkersUnderWords(const String& node_text, 29 bool RemoveMarkersUnderWords(const String& node_text,
30 const Vector<String>& words); 30 const Vector<String>& words);
31 bool ShiftMarkers(unsigned offset, 31 bool ShiftMarkers(unsigned offset,
32 unsigned old_length, 32 unsigned old_length,
33 unsigned new_length) final; 33 unsigned new_length) final;
34 34
35 DECLARE_VIRTUAL_TRACE(); 35 DECLARE_VIRTUAL_TRACE();
36 36
37 protected:
38 SpellCheckMarkerListImpl() = default;
39
37 private: 40 private:
38 HeapVector<Member<RenderedDocumentMarker>> markers_; 41 HeapVector<Member<RenderedDocumentMarker>> markers_;
39 42
40 DISALLOW_COPY_AND_ASSIGN(SpellCheckMarkerListImpl); 43 DISALLOW_COPY_AND_ASSIGN(SpellCheckMarkerListImpl);
41 }; 44 };
42 45
46 DEFINE_TYPE_CASTS(SpellCheckMarkerListImpl,
47 DocumentMarkerList,
48 list,
49 true,
yosin_UTC9 2017/05/15 02:17:28 MarkerType() == kSpellingMarker and MarkerType() =
rlanday 2017/05/15 02:27:11 Oh wow, I think I was missing the forest for the t
50 true);
51
43 } // namespace blink 52 } // namespace blink
44 53
45 #endif // SpellCheckMarkerListImpl_h 54 #endif // SpellCheckMarkerListImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698