Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: base/task_scheduler/task.cc

Issue 2873453002: Add base::TaskTraits::Override(). (Closed)
Patch Set: CR-gab Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_scheduler/post_task.cc ('k') | base/task_scheduler/task_traits.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task.h" 5 #include "base/task_scheduler/task.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/critical_closure.h" 9 #include "base/critical_closure.h"
10 10
11 namespace base { 11 namespace base {
12 namespace internal { 12 namespace internal {
13 13
14 Task::Task(const tracked_objects::Location& posted_from, 14 Task::Task(const tracked_objects::Location& posted_from,
15 OnceClosure task, 15 OnceClosure task,
16 const TaskTraits& traits, 16 const TaskTraits& traits,
17 TimeDelta delay) 17 TimeDelta delay)
18 : PendingTask( 18 : PendingTask(
19 posted_from, 19 posted_from,
20 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN 20 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN
21 ? MakeCriticalClosure(std::move(task)) 21 ? MakeCriticalClosure(std::move(task))
22 : std::move(task), 22 : std::move(task),
23 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay, 23 delay.is_zero() ? TimeTicks() : TimeTicks::Now() + delay,
24 false), // Not nestable. 24 false), // Not nestable.
25 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before 25 // Prevent a delayed BLOCK_SHUTDOWN task from blocking shutdown before
26 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN. 26 // being scheduled by changing its shutdown behavior to SKIP_ON_SHUTDOWN.
27 traits(!delay.is_zero() && traits.shutdown_behavior() == 27 traits(
28 TaskShutdownBehavior::BLOCK_SHUTDOWN 28 (!delay.is_zero() &&
29 ? TaskTraits(traits).WithShutdownBehavior( 29 traits.shutdown_behavior() == TaskShutdownBehavior::BLOCK_SHUTDOWN)
30 TaskShutdownBehavior::SKIP_ON_SHUTDOWN) 30 ? TaskTraits::Override(traits,
31 : traits), 31 {TaskShutdownBehavior::SKIP_ON_SHUTDOWN})
32 : traits),
32 delay(delay) {} 33 delay(delay) {}
33 34
34 Task::~Task() = default; 35 Task::~Task() = default;
35 36
36 } // namespace internal 37 } // namespace internal
37 } // namespace base 38 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/post_task.cc ('k') | base/task_scheduler/task_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698