base/memory/shared_memory.cc - Issue 2873433004: Replace SharedMemory::UniqueID usages with SharedMemoryHandle's guid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/memory/shared_memory.cc

Issue 2873433004: Replace SharedMemory::UniqueID usages with SharedMemoryHandle's guid (Closed)

Patch Set: Address on reviews Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/memory/shared_memory.h"

	6

	7 namespace base {

	8

	9 base::UnguessableToken SharedMemory::GetGUID() const {
	Primiano Tucci (use gerrit) 2017/05/10 18:33:55 out of curiosity, why this is not an inline getter out of curiosity, why this is not an inline getter? it seems this is just a trivial accessor. hajimehoshi 2017/05/11 10:26:00 I thought this used indirect way to get handle rat Show quoted text On 2017/05/10 18:33:55, Primiano Tucci wrote: > out of curiosity, why this is not an inline getter? it seems this is just a > trivial accessor. I thought this used indirect way to get handle rather than returning its own field. On second thought, this was not worth creating a new cc file. Anyway, I just removed this function.
	10 return handle().GetGUID();

	11 }

	12

	13 } // namespace base

OLD	NEW