Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: base/memory/shared_memory_posix.cc

Issue 2873433004: Replace SharedMemory::UniqueID usages with SharedMemoryHandle's guid (Closed)
Patch Set: Address on reviews Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_tracker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/shared_memory.h" 5 #include "base/memory/shared_memory.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #include <stddef.h> 9 #include <stddef.h>
10 #include <sys/mman.h> 10 #include <sys/mman.h>
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 *path = temp_dir.AppendASCII(name_base + ".shmem." + mem_name); 352 *path = temp_dir.AppendASCII(name_base + ".shmem." + mem_name);
353 return true; 353 return true;
354 } 354 }
355 #endif // !defined(OS_ANDROID) 355 #endif // !defined(OS_ANDROID)
356 356
357 SharedMemoryHandle SharedMemory::GetReadOnlyHandle() { 357 SharedMemoryHandle SharedMemory::GetReadOnlyHandle() {
358 CHECK(readonly_shm_.IsValid()); 358 CHECK(readonly_shm_.IsValid());
359 return readonly_shm_.Duplicate(); 359 return readonly_shm_.Duplicate();
360 } 360 }
361 361
362 bool SharedMemory::GetUniqueId(SharedMemory::UniqueId* id) const {
363 // This function is called just after mmap. fstat is a system call that might
364 // cause I/O. It's safe to call fstat here because mmap for shared memory is
365 // called in two cases:
366 // 1) To handle file-mapped memory
367 // 2) To handle annonymous shared memory
368 // In 1), I/O is already permitted. In 2), the backend is on page cache and
369 // fstat doesn't cause I/O access to the disk. See the discussion at
370 // crbug.com/604726#c41.
371 base::ThreadRestrictions::ScopedAllowIO allow_io;
372 struct stat file_stat;
373 if (HANDLE_EINTR(
374 ::fstat(static_cast<int>(handle().GetHandle()), &file_stat)) != 0)
375 return false;
376 id->first = file_stat.st_dev;
377 id->second = file_stat.st_ino;
378 return true;
379 }
380
381 } // namespace base 362 } // namespace base
OLDNEW
« no previous file with comments | « base/memory/shared_memory.h ('k') | base/memory/shared_memory_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698