Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp

Issue 2873433003: Move MediaQuery classes off BlinkGC heap (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
diff --git a/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp b/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
index 7b2273783879993edd930cbab3f40b5e1753b6d3..4de15febf5eb598d2cea6bade9b16ed43f742a40 100644
--- a/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
+++ b/third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp
@@ -139,10 +139,10 @@ TestCase printTestCases[] = {
void testMQEvaluator(TestCase* testCases,
const MediaQueryEvaluator& mediaQueryEvaluator) {
- Persistent<MediaQuerySet> querySet = nullptr;
+ RefPtr<MediaQuerySet> querySet = nullptr;
for (unsigned i = 0; testCases[i].input; ++i) {
querySet = MediaQuerySet::create(testCases[i].input);
- EXPECT_EQ(testCases[i].output, mediaQueryEvaluator.eval(querySet.get()));
+ EXPECT_EQ(testCases[i].output, mediaQueryEvaluator.eval(*querySet));
}
}
@@ -193,8 +193,8 @@ TEST(MediaQueryEvaluatorTest, DynamicNoView) {
pageHolder.reset();
ASSERT_EQ(nullptr, frame->view());
MediaQueryEvaluator mediaQueryEvaluator(frame);
- MediaQuerySet* querySet = MediaQuerySet::create("foobar");
- EXPECT_FALSE(mediaQueryEvaluator.eval(querySet));
+ RefPtr<MediaQuerySet> querySet = MediaQuerySet::create("foobar");
+ EXPECT_FALSE(mediaQueryEvaluator.eval(*querySet));
}
TEST(MediaQueryEvaluatorTest, CachedFloatViewport) {
« no previous file with comments | « third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp ('k') | third_party/WebKit/Source/core/css/MediaQueryExp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698