third_party/WebKit/Source/modules/payments/PaymentRequest.cpp - Issue 2873433002: Enable Feature Policy without experimental features or fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2873433002: Enable Feature Policy without experimental features or fullscreen (Closed)

Patch Set: Fix test failure (fullscreen is still behind FeaturePolicy flag and only disabled in-place of IsSup… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

index 9759e63f2eccaaa13af83dcfd05b94e0cb542119..d6e15e450d0e0545943e0cf353cd6b3db33978fb 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

@@ -40,6 +40,7 @@

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/UUID.h"

#include "platform/bindings/ScriptState.h"

+#include "platform/feature_policy/FeaturePolicy.h"

#include "platform/mojo/MojoHelper.h"

#include "platform/wtf/HashSet.h"

#include "public/platform/InterfaceProvider.h"

@@ -599,7 +600,7 @@ bool AllowedToUsePaymentRequest(const Frame* frame) {

if (!frame)

return false;

- if (!RuntimeEnabledFeatures::featurePolicyEnabled()) {

+ if (!IsSupportedInFeaturePolicy(WebFeaturePolicyFeature::kPayment)) {

// 2. If |document|'s browsing context is a top-level browsing context, then

// return true.

if (frame->IsMainFrame())