third_party/WebKit/Source/core/dom/Fullscreen.cpp - Issue 2873433002: Enable Feature Policy without experimental features or fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2873433002: Enable Feature Policy without experimental features or fullscreen (Closed)

Patch Set: Fix test failure (fullscreen is still behind FeaturePolicy flag and only disabled in-place of IsSup… Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp

diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

index f0e48fbf779f72f15e131b0357344568cdd7f096..a40e830bb426dbd82b7898d3faeb7deee22442c8 100644

--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp

+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp

@@ -49,6 +49,7 @@

#include "core/svg/SVGSVGElement.h"

#include "platform/ScopedOrientationChangeIndicator.h"

#include "platform/UserGestureIndicator.h"

+#include "platform/feature_policy/FeaturePolicy.h"

namespace blink {

@@ -63,7 +64,7 @@ bool AllowedToUseFullscreen(const Frame* frame) {

if (!frame)

return false;

- if (!RuntimeEnabledFeatures::featurePolicyEnabled()) {

+ if (!IsSupportedInFeaturePolicy(WebFeaturePolicyFeature::kFullscreen)) {

// 2. If |document|'s browsing context is a top-level browsing context, then

// return true.

if (frame->IsMainFrame())