Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp

Issue 2873433002: Enable Feature Policy without experimental features or fullscreen (Closed)
Patch Set: Update webkit_unit_tests(vibrate is not valid feature name) and layout_tests for fp-fullscreen (exp… Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
diff --git a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
index f89c965b35075a0057e00fe885d3e977f2c26074..ea002291e5040b42898fbad9212b02b9d1baefe0 100644
--- a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
+++ b/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
@@ -112,7 +112,6 @@ WebParsedFeaturePolicy GetContainerPolicyFromAllowedFeatures(
override_payment = true;
if (feature == WebFeaturePolicyFeature::kFullscreen)
override_fullscreen = true;
-
WebParsedFeaturePolicyDeclaration whitelist;
whitelist.feature = feature;
whitelist.origins = Vector<WebSecurityOrigin>(1UL, {origin});
@@ -131,9 +130,9 @@ WebParsedFeaturePolicy GetContainerPolicyFromAllowedFeatures(
const FeatureNameMap& GetDefaultFeatureNameMap() {
DEFINE_STATIC_LOCAL(FeatureNameMap, default_feature_name_map, ());
if (default_feature_name_map.IsEmpty()) {
+ default_feature_name_map.Set("payment", WebFeaturePolicyFeature::kPayment);
iclelland 2017/05/09 17:58:45 This change looks unintentional; I'd prefer to not
lunalu1 2017/05/09 19:07:31 Done.
default_feature_name_map.Set("fullscreen",
WebFeaturePolicyFeature::kFullscreen);
- default_feature_name_map.Set("payment", WebFeaturePolicyFeature::kPayment);
if (RuntimeEnabledFeatures::featurePolicyExperimentalFeaturesEnabled()) {
default_feature_name_map.Set("vibrate",
WebFeaturePolicyFeature::kVibrate);

Powered by Google App Engine
This is Rietveld 408576698