Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp

Issue 2873433002: Enable Feature Policy without experimental features or fullscreen (Closed)
Patch Set: Update webkit_unit_tests(vibrate is not valid feature name) and layout_tests for fp-fullscreen (exp… Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
index 7c43dc64f0d81767cbfff9da21d912289a8c8cc4..724c7c85b570167181752918bb5f1a3f92accf95 100644
--- a/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElementAllowTest.cpp
@@ -29,11 +29,10 @@ TEST(HTMLIFrameElementAllowTest, ParseAllowedFeatureNamesValid) {
EXPECT_THAT(result,
UnorderedElementsAre(WebFeaturePolicyFeature::kFullscreen));
- allow->setValue("fullscreen payment vibrate");
+ allow->setValue("fullscreen payment");
result = allow->ParseAllowedFeatureNames(error_message);
EXPECT_THAT(result, UnorderedElementsAre(WebFeaturePolicyFeature::kFullscreen,
- WebFeaturePolicyFeature::kPayment,
- WebFeaturePolicyFeature::kVibrate));
+ WebFeaturePolicyFeature::kPayment));
}
TEST(HTMLIFrameElementAllowTest, ParseAllowedFeatureNamesInvalid) {
@@ -54,11 +53,11 @@ TEST(HTMLIFrameElementAllowTest, ParseAllowedFeatureNamesInvalid) {
UnorderedElementsAre(WebFeaturePolicyFeature::kFullscreen));
EXPECT_EQ("'invalid1', 'invalid2' are invalid feature names.", error_message);
- allow->setValue("fullscreen invalid vibrate fullscreen");
+ allow->setValue("fullscreen invalid payment fullscreen");
result = allow->ParseAllowedFeatureNames(error_message);
EXPECT_EQ("'invalid' is an invalid feature name.", error_message);
EXPECT_THAT(result, UnorderedElementsAre(WebFeaturePolicyFeature::kFullscreen,
- WebFeaturePolicyFeature::kVibrate));
+ WebFeaturePolicyFeature::kPayment));
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698