Issue 287343006: ui/base and some other GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287343006: ui/base and some other GN build (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, piman+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GN build improvements, misc plus Parameterize webrtc enabling. Add use_seccomp_pbf flag Add a webkit version target Work on ui/base GN build, especially on Windows. This target is a mess (in GYP). This patch tries to make it make a bit more sense while fixing the errors I found. Fix ui/gl target for non-Linux platform. A bunch of X11 stuff was not parameterized. Add unscaled resources target BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271724

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -40 lines)			Patch
M	build/config/BUILD.gn	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	build/config/features.gni	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	build/util/BUILD.gn	View		2 chunks	+19 lines, -1 line	0 comments	Download
M	gpu/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/BUILD.gn	View		9 chunks	+31 lines, -33 lines	0 comments	Download
M	ui/gl/BUILD.gn	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/resources/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/287343006/diff/1/build/config/features.gni File build/config/features.gni (right): https://codereview.chromium.org/287343006/diff/1/build/config/features.gni#newcode55 build/config/features.gni:55: use_seccomp_bpf = is_linux || is_android && parens around ...

6 years, 7 months ago (2014-05-20 19:06:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r271724.

Expand Messages | Collapse Messages