Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc

Issue 2873393004: [Offline pages] Stop observing web contents and reset to null after use. Only create a new web cont… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/background_loader_offliner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
index 77dd44d2ba93fffe27d78a92e88418dc30c0adeb..fa2082aa432060ab5ad79f37b160d94a2b4c1eaa 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
@@ -94,10 +94,10 @@ class TestBackgroundLoaderOffliner : public BackgroundLoaderOffliner {
content::WebContents* web_contents() { return stub_->web_contents(); }
- bool is_loading() { return stub_->is_loading(); }
+ bool is_loading() { return loader_ && stub_->is_loading(); }
protected:
- void ResetState() override;
+ void ResetLoader() override;
private:
background_loader::BackgroundLoaderContentsStub* stub_;
@@ -111,11 +111,9 @@ TestBackgroundLoaderOffliner::TestBackgroundLoaderOffliner(
TestBackgroundLoaderOffliner::~TestBackgroundLoaderOffliner() {}
-void TestBackgroundLoaderOffliner::ResetState() {
- pending_request_.reset();
+void TestBackgroundLoaderOffliner::ResetLoader() {
stub_ = new background_loader::BackgroundLoaderContentsStub(browser_context_);
loader_.reset(stub_);
- content::WebContentsObserver::Observe(stub_->web_contents());
}
class BackgroundLoaderOfflinerTest : public testing::Test {
« no previous file with comments | « chrome/browser/android/offline_pages/background_loader_offliner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698