Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html

Issue 2873373004: Remove duplicate service worker test (Closed)
Patch Set: Un-register workers following test completion Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/onactivate-script-error.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html
index 23a7f2c86868ee57b0556b63c1caa23d6db40c8f..6c16357f3cc5aba181ee0798ac9fadc2388c3f3a 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/onactivate-script-error.https.html
@@ -33,16 +33,15 @@ function make_test(name, script) {
return service_worker_unregister_and_register(t, script, scope)
.then(function(r) {
registration = r;
+
+ t.add_cleanup(function() {
+ r.unregister();
+ });
+
return wait_for_install(registration.installing);
})
.then(function() {
// Activate should succeed regardless of script errors.
- if (registration.active && registration.active.state == 'activated') {
- return Promise.resolve();
- } else if (registration.active) {
- return wait_for_activate(registration.active);
- }
-
return wait_for_activate(registration.waiting);
});
}, name);
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/onactivate-script-error.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698